fix(i18n/gi18n): Fix issue where gi18n does not allow keyword-level access#4781
Open
chaegumi wants to merge 9 commits into
Open
fix(i18n/gi18n): Fix issue where gi18n does not allow keyword-level access#4781chaegumi wants to merge 9 commits into
chaegumi wants to merge 9 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Issue #4780 by improving gi18n translation lookup so TOML/JSON hierarchical keys can be accessed using dot notation in templates (e.g. {#app.site_name}), aligning i18n behavior with structured config formats.
Changes:
- Change i18n storage from
map[string]stringtomap[string]anyto preserve hierarchical data loaded from TOML/JSON. - Use
gjson-style pattern access duringTranslateplaceholder replacement to supporta.b.clookups and dotted key-name compatibility. - Ensure
GetContentreturns strings fromanyvalues viagconv.String.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ests - Lazily create gjson object only when dotted keys are encountered, avoiding expensive gconv.Map deep conversion - Reset ViolenceCheck after each lookup to prevent affecting subsequent substitutions - Add direct map lookup for non-dotted keys for better performance - Add Test_ViolenceCheck and Test_DottedKeyResolution regression tests - Add test data files in testdata/violence-check/ and testdata/dotted-key/
chaegumi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修复这个bug #4780