style(clippy): use struct update syntax in create_work_item test - #2011
Draft
github-actions[bot] wants to merge 1 commit into
Draft
style(clippy): use struct update syntax in create_work_item test#2011github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Fixes clippy::field_reassign_with_default for test_patch_field_validation_rejects_description_field_title_collision. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 1 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What clippy found
cargo clippy --all-targets --all-features --workspace -- -D warningsfailed (exit 101) with this single finding intest_patch_field_validation_rejects_description_field_title_collision.How it was fixed
clippy::field_reassign_with_defaultlet mut config = CreateWorkItemConfig::default(); config.description_field = Some(...)with struct-update syntax (CreateWorkItemConfig { description_field: Some(...), ..Default::default() }), matching the pattern clippy suggests and avoids the redundant intermediate mutable default.src/safe_outputs/create_work_item.rs(test-only change, 4 insertions / 2 deletions)Verification
cargo build --all-targets— passcargo test— 3229 passed, 0 failed (plus all other integration test binaries green)cargo clippy --all-targets --all-features --workspace -- -D warnings— exit 0, cleanWarning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
spsprodeus21.vssps.visualstudio.comTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.