Add 4 new partners to Partner Pack (tab hidden until launch)#415
Add 4 new partners to Partner Pack (tab hidden until launch)#415ashleywolf merged 12 commits intomainfrom
Conversation
ashleywolf
requested review from
AndreaGriffiths11,
LadyKerr and
cassidoo
as code owners
There was a problem hiding this comment.
Pull request overview
Adds four new Partner Pack partner offers (as content entries) and associated logo assets, and hides the Partner Pack tab in the header until launch.
Changes:
- Added 4 new offer frontmatter files under
content/partner-pack/offers/(Daytona, Ref.tools, Radix/.Tech, OSI). - Added 2 new partner logo images under
public/images/partners/(Daytona, OSI). - Attempted to hide the Partner Pack navigation entry in
Header.jsx.
Show a summary per file
| File | Description |
|---|---|
| public/images/partners/osi.png | Adds OSI logo asset for Partner Pack rendering. |
| public/images/partners/daytona.png | Adds Daytona logo asset for Partner Pack rendering. |
| content/partner-pack/offers/reftools.md | Adds Ref.tools offer metadata (logo filename currently missing in /public/images/partners). |
| content/partner-pack/offers/radix.md | Adds Radix/.Tech offer metadata (logo filename currently missing in /public/images/partners). |
| content/partner-pack/offers/osi.md | Adds OSI offer metadata referencing the new OSI logo. |
| content/partner-pack/offers/daytona.md | Adds Daytona offer metadata referencing the new Daytona logo. |
| components/header/Header.jsx | Hides the Partner Pack nav item (currently does so in a way that breaks JSX). |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 5/7 changed files
- Comments generated: 3
| <li> | ||
| <Link | ||
| href={ROUTES.PARTNER_PACK.getPath(year)} | ||
| aria-label={getLiteral('navigation:partner-pack')} | ||
| className={clsx('header__link', { | ||
| ['is-active']: pathname === ROUTES.PARTNER_PACK.getPath(year), | ||
| })} | ||
| > | ||
| <BoxGift /> | ||
| <span className="header__link-text"> | ||
| {getLiteral('navigation:partner-pack')} | ||
| </span> | ||
| </Link> | ||
| </li> | ||
| {/* HIDDEN FOR REVIEW - href={ROUTES.PARTNER_PACK.getPath(year)} */} | ||
| {/* HIDDEN FOR REVIEW - aria-label={getLiteral('navigation:partner-pack')} */} | ||
| {/* HIDDEN FOR REVIEW - className={clsx('header__link', { */} | ||
| {/* HIDDEN FOR REVIEW - ['is-active']: pathname === ROUTES.PARTNER_PACK.getPath(year), */} |
There was a problem hiding this comment.
The Partner Pack nav item is commented out in a way that leaves an unterminated <Link element (no props and no closing >), which will cause a JSX parse/build failure. Hide the nav item by removing the entire <li>…</li> block or wrapping it in a conditional (e.g., {showPartnerPack && (...)}) so the JSX stays syntactically valid (and avoids leaving BoxGift/route references only in comments).
| @@ -0,0 +1,8 @@ | |||
| --- | |||
| name: "Ref.tools" | |||
| logo: "reftools.png" | |||
There was a problem hiding this comment.
This offer references logo: "reftools.png", but there is no corresponding file in public/images/partners/ in this PR. When the Offers UI is enabled, this will render as a broken image. Either add the logo asset, or temporarily point logo at an existing placeholder until the PNG is available.
| logo: "reftools.png" |
| @@ -0,0 +1,8 @@ | |||
| --- | |||
| name: "Radix / .Tech" | |||
| logo: "radix.png" | |||
There was a problem hiding this comment.
This offer references logo: "radix.png", but there is no corresponding file in public/images/partners/ in this PR. When the Offers UI is enabled, this will render as a broken image. Either add the logo asset, or temporarily point logo at an existing placeholder until the PNG is available.
| logo: "radix.png" |
Adds 4 new confirmed partners to the Partner Pack page:
Changes:
Still needed before unhiding the tab:
The page is still accessible via direct URL (/partner-pack) for review.