Skip to content

add .history folder to gitignore#2651

Closed
samuelstein wants to merge 1 commit into
github:masterfrom
samuelstein:patch-1
Closed

add .history folder to gitignore#2651
samuelstein wants to merge 1 commit into
github:masterfrom
samuelstein:patch-1

Conversation

@samuelstein

Copy link
Copy Markdown

Ignore local history changes from .history folder

Ignore local history changes from .history folder
@shiftkey

shiftkey commented Apr 6, 2018

Copy link
Copy Markdown
Member

@samuelstein any links to StackOverflow discussions or other documentation about this change?

@samuelstein

Copy link
Copy Markdown
Author

!.vscode/tasks.json
!.vscode/launch.json
!.vscode/extensions.json
.history

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be inside .vscode/? If so, it should be covered by the rule on line 1

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no the folder is outside of .vscode

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see some documentation that explains this file better - describing the feature is one thing, but it'd be nice to confirm we're looking at the right file in the right location before merging this in.

It also seems suboptimal for this to not be using the .vscode folder, especially if it's an in-the-box feature of VSCode, for what looks like a generated file.

@sara0871

Copy link
Copy Markdown

👋

@samuelstein

samuelstein commented Apr 26, 2018

Copy link
Copy Markdown
Author

i could not find better official documentation. @shiftkey try it for yourself. got to user settings and activate it via "local-history.enabled": 1,

@shiftkey

shiftkey commented Apr 30, 2018

Copy link
Copy Markdown
Member

On VSCode 1.22.2 (macOS) I don't seem to be able to enable this feature:

@shiftkey

Copy link
Copy Markdown
Member

Closing this out as I'm not able to understand the requested change and verify it's correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants