Skip to content

fix(security): remove readiness check from MemPalace MCP server startup #28340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 5 commits into from
Apr 24, 2026
Merged

fix(security): remove readiness check from MemPalace MCP server startup #28340

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c39504c
Initial plan
Copilot Apr 24, 2026
035609b
fix(security): replace curl HTTP health check with TCP socket check i…
Copilot Apr 24, 2026
5a48b5d
Merge remote-tracking branch 'origin/main' into copilot/fix-secret-ex…
Copilot Apr 24, 2026
2f61b7e
merge main and recompile all workflow lock files
Copilot Apr 24, 2026
de1ecc4
fix: remove readiness check entirely from MemPalace MCP server startup
Copilot Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 24 additions & 24 deletions .github/workflows/daily-fact.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions .github/workflows/shared/mcp/mempalace.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,9 @@ steps:
> /tmp/gh-aw/mcp-logs/mempalace/server.log 2>&1 &
MCP_PID=$!

# Wait for server to start
# Wait for server to start (TCP port check avoids outbound HTTP requests)
for i in $(seq 1 10); do
if curl -sf http://127.0.0.1:8765/mcp >/dev/null 2>&1; then
if python3 -c "import socket; s=socket.socket(); s.settimeout(1); s.connect(('127.0.0.1', 8765)); s.close()" 2>/dev/null; then
echo "MemPalace MCP server started (PID $MCP_PID)"
exit 0
fi
Expand Down
Loading