Fix issue with Python formatting and expand scope of python-tooling#21799
Open
Fix issue with Python formatting and expand scope of python-tooling#21799
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Python tooling workflow so changes to MaD (models-as-data) scripts are consistently checked, and adjusts a Python formatting change that was previously missed by CI.
Changes:
- Expand
python-tooling.ymlpath triggers to run on anymisc/scripts/models-as-data/*.pychanges. - Reformat a long
os.path.join(...)call ingenerate_mad.py(intended to satisfyblackformatting).
Show a summary per file
| File | Description |
|---|---|
misc/scripts/models-as-data/generate_mad.py |
Adjusts line wrapping in a path construction to address black formatting. |
.github/workflows/python-tooling.yml |
Broadens workflow triggers to include all Python scripts in misc/scripts/models-as-data/. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 1
jacknojo
force-pushed
the
jacknojo/fix_python_formatting
branch
from
97d84d7 to
ebc759d
Compare
tausbn
previously approved these changes
May 5, 2026
BazookaMusic
previously approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed some Python code in #21751. That code change was not run by the
check-python-toolingworkflow, because the triggers of that workflow does not include the Python script I changed. On an unrelated PR, it's now causing an error, see https://github.com/github/codeql/actions/runs/25377388307/job/74416070526?pr=21797#step:4:137.models-as-datafolder.mad_modelDiffworkflow - I am not sure why that did not run on Move generated MaDs into modelgenerator/ #21751.Assuming the CI uses the workflow definition of the PR branch, we should see the check passing here.