LGTM 1.18: finalize the JavaScript change notes#182
Merged
Conversation
Contributor
All of them. |
Contributor
|
@felicity-semmle should I merge this, or are you planning to add the extractor change notes in the same PR? |
Contributor
Author
|
Thanks for asking. I'm happy to leave the extractor notes where they are, since that workflow works better while you're writing them. I'll combine them when I update the embedded change notes for the LGTM user help and also the wiki topics for QL users. |
aibaars
pushed a commit
that referenced
this pull request
Oct 14, 2021
smowton
pushed a commit
to smowton/codeql
that referenced
this pull request
Jan 17, 2022
…ions Change unknown location to whole file location in source extraction
MathiasVP
pushed a commit
to MathiasVP/ql
that referenced
this pull request
Aug 10, 2025
…ow-2 PS: Fix parameter/argument name mapping for named parameters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to get the JavaScript change notes ready for the next release. I tried to separate out changes into different commits, but I'm not sure how successful that was. Strangely the rich diff seems much easier to navigate than the plain text diff.
Key changes:
I hadn't expected to make so many changes, so I hope that none of them are too controversial.
@Semmle/js - please check that I haven't introduced any errors. Perhaps you can also tell me how many of the changes to code extraction in
extractor-javascript.mdaffect LGTM users? I'm assuming that at least the last bullet in that file needs to be incorporated in the change notes that we embed in the help for LGTM Enterprise users.