C++: Remove CP in getOperandMemoryAccess#134
Merged
Merged
Conversation
The overrides of `Instruction.getOperandMemoryAccess` did not relate `this` to any of its other parameters, which made it attempt to compute the Cartesian product of `Instruction` and `TPhiOperand`. This happened only during computation of aliased SSA. Perhaps the optimizer was able to eliminate the CP for the non-aliased SSA computation. With this change, I'm able to compute aliased SSA for medium-sized snapshots.
jbj
force-pushed
the
getOperandMemoryAccess-this
branch
from
0cbd5ec to
e0c0733
Compare
Contributor
Author
|
Rebased to fix conflicts. |
dave-bartolomeo
approved these changes
Sep 5, 2018
Contributor
dave-bartolomeo
left a comment
dave-bartolomeo
left a comment
There was a problem hiding this comment.
LGTM
I seem to make this mistake a lot.
aibaars
added a commit
that referenced
this pull request
Oct 14, 2021
Add and expand AST classes for literals
smowton
pushed a commit
to smowton/codeql
that referenced
this pull request
Dec 6, 2021
Kotlin: Add more classes tests
MathiasVP
added a commit
to MathiasVP/ql
that referenced
this pull request
Aug 10, 2025
PS: Add API graphs and models-as-data libraries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The overrides of
Instruction.getOperandMemoryAccessdid not relatethisto any of its other parameters, which made it attempt to compute the Cartesian product ofInstructionandTPhiOperand. This happened only during computation of aliased SSA. Perhaps the optimizer was able to eliminate the CP for the non-aliased SSA computation.With this change, I'm able to compute aliased SSA for medium-sized snapshots. Without this change, aliased SSA isn't usable for me in 1.18.