-
Notifications
You must be signed in to change notification settings - Fork 75
CTR55-CPP: Consider iter != last to be a bounds check #374
Copy link
Copy link
Closed
Labels
Difficulty-MediumA false positive or false negative report which is expected to take 1-5 days effort to addressA false positive or false negative report which is expected to take 1-5 days effort to addressImpact-MediumPhase IIfalse positive/false negativeAn issue related to observed false positives or false negatives.An issue related to observed false positives or false negatives.user-reportIssue reported by an end user of CodeQL Coding StandardsIssue reported by an end user of CodeQL Coding Standards
Metadata
Metadata
Assignees
Labels
Difficulty-MediumA false positive or false negative report which is expected to take 1-5 days effort to addressA false positive or false negative report which is expected to take 1-5 days effort to addressImpact-MediumPhase IIfalse positive/false negativeAn issue related to observed false positives or false negatives.An issue related to observed false positives or false negatives.user-reportIssue reported by an end user of CodeQL Coding StandardsIssue reported by an end user of CodeQL Coding Standards
Type
Fields
Give feedbackNo fields configured for issues without a type.
Projects
Status
Done
Affected rules
CTR55-CPPDescription
This query has a fairly restricted view of what a valid bounds check consists of. Consider expanding to support
iter != lastas a valid bound check, iflastis derived fromend(). We should also consider the case of utility methods on iterators, and whether they are correct at the call site.Example
for (; iter != end; ++iter) { }