run-command: be helpful when Git LFS fails on Windows 7#5042
Merged
Conversation
Member
Author
|
This is how the error message looks now: |
1 task
rimrul
reviewed
Jul 5, 2024
chrisd8088
reviewed
Jul 8, 2024
There was a problem hiding this comment.
Thank you so much for tackling this challenge! I really appreciate the effort here, and I've learned a ton from doing a review about both the Windows and MS-DOS executable file formats and Go's own linker and file format internals.
I had a few suggestions only; out of them all, the main thing I wondered about was whether the get_go_version() function could accidentally read past the end of the data in its p while trying to parse the various pieces of the Go header and version string, etc., if the input data was bad or malicious or whatever.
So I tried to write up and test some code which might check for that condition and a few others; I ran a variety of experiments with bad input data, but I won't claim I did a completely exhaustive set of checks.
I have also set up a Windows 7 SP1 VM, and see the problem with the current Git for Windows distribution this PR aims to work around, but I haven't yet tried compiling enough of Git to get this PR's changes (with or without my suggestions) running in the VM and testable. I hope to get to that soon.
Thanks again very much for all the investigation and work to try to help out our Git LFS users on old Windows systems! 🙇
Member
Author
|
@chrisd8088 thank you for your review! I will reply to your concerns in the threads, except for this one:
FWIW you could simply download the PR build artifacts and overwrite |
Ah, thanks -- I've done that before for Git LFS build artifacts. (There's a bit of work getting them onto the VM, but it's doable.) |
dscho
changed the title
dscho
force-pushed
the
warn-about-git-lfs-on-win7
branch
from
July 9, 2024 10:42
1fe2fa9 to
c99be51
Compare
Member
Author
|
@chrisd8088 wow, what a thorough review! I do not see a lot of such high-quality reviews on the Git mailing list, and I am delighted. Thank you so, so much. I force-pushed an update that addresses your comments as well as the bug where 32-bit Could you have a final look over the diff before I merge the PR? |
chrisd8088
reviewed
Jul 9, 2024
chrisd8088
left a comment
chrisd8088
left a comment
There was a problem hiding this comment.
Glad to help! It's been fun doing some C coding again; I know it's a language with flaws, but I miss reading and writing it.
Speaking of the flaws of C, though, I think the current version of this code may still read past the end of p in one specific case, which I tried to outline in my latest comments.
Git LFS is now built with Go 1.21 which no longer supports Windows 7. However, Git for Windows still wants to support Windows 7. Ideally, Git LFS would re-introduce Windows 7 support until Git for Windows drops support for Windows 7, but that's not going to happen: git-for-windows#4996 (comment) The next best thing we can do is to let the users know what is happening, and how to get out of their fix, at least. This is not quite as easy as it would first seem because programs compiled with Go 1.21 or newer will simply throw an exception and fail with an Access Violation on Windows 7. The only way I found to address this is to replicate the logic from Go's very own `version` command (which can determine the Go version with which a given executable was built) to detect the situation, and in that case offer a helpful error message. This addresses git-for-windows#4996. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
force-pushed
the
warn-about-git-lfs-on-win7
branch
from
July 10, 2024 08:51
c99be51 to
3324d3b
Compare
Member
Author
|
/add relnote bug Git LFS v3.5.x and newer no longer support Windows 7. Instead of a helpful error message, it now simply crashes on that Windows version, leaving the user with the error message "panic before malloc heap initialized". This has been addressed: In addition to the unhelpful error message, Git is now saying what is going on and how to get out of the situation. The workflow run was started |
github-actions Bot
pushed a commit
to git-for-windows/build-extra
that referenced
this pull request
Jul 10, 2024
![gitforwindowshelper[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
Git LFS v3.5.x and newer no longer support Windows 7. Instead of a helpful error message, it now simply [crashes](git-for-windows/git#4996) on that Windows version, leaving the user with the error message "panic before malloc heap initialized". This has been [addressed](git-for-windows/git#5042): In addition to the unhelpful error message, Git is now saying what is going on and how to get out of the situation. Signed-off-by: gitforwindowshelper[bot] <gitforwindowshelper-bot@users.noreply.github.com>
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 10, 2024
Git LFS is now built with Go 1.21 which no longer supports Windows 7. However, Git for Windows still wants to support Windows 7. Ideally, Git LFS would re-introduce Windows 7 support until Git for Windows drops support for Windows 7, but that's [not going to happen](#4996 (comment)). The next best thing we can do is to let the users know what is happening, and how to get out of their fix, at least. This is not quite as easy as it would first seem because programs compiled with Go 1.21 or newer will simply throw an exception and fail with an Access Violation on Windows 7. The only way I found to address this is to replicate the logic from Go's very own `version` command (which can determine the Go version with which a given executable was built) to detect the situation, and in that case offer a helpful error message. This addresses #4996. /cc @chrisd8088
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 10, 2024
Git LFS is now built with Go 1.21 which no longer supports Windows 7. However, Git for Windows still wants to support Windows 7. Ideally, Git LFS would re-introduce Windows 7 support until Git for Windows drops support for Windows 7, but that's [not going to happen](#4996 (comment)). The next best thing we can do is to let the users know what is happening, and how to get out of their fix, at least. This is not quite as easy as it would first seem because programs compiled with Go 1.21 or newer will simply throw an exception and fail with an Access Violation on Windows 7. The only way I found to address this is to replicate the logic from Go's very own `version` command (which can determine the Go version with which a given executable was built) to detect the situation, and in that case offer a helpful error message. This addresses #4996. /cc @chrisd8088
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 10, 2024
Git LFS is now built with Go 1.21 which no longer supports Windows 7. However, Git for Windows still wants to support Windows 7. Ideally, Git LFS would re-introduce Windows 7 support until Git for Windows drops support for Windows 7, but that's [not going to happen](#4996 (comment)). The next best thing we can do is to let the users know what is happening, and how to get out of their fix, at least. This is not quite as easy as it would first seem because programs compiled with Go 1.21 or newer will simply throw an exception and fail with an Access Violation on Windows 7. The only way I found to address this is to replicate the logic from Go's very own `version` command (which can determine the Go version with which a given executable was built) to detect the situation, and in that case offer a helpful error message. This addresses #4996. /cc @chrisd8088
dscho
added a commit
that referenced
this pull request
Jul 10, 2024
Git LFS is now built with Go 1.21 which no longer supports Windows 7. However, Git for Windows still wants to support Windows 7. Ideally, Git LFS would re-introduce Windows 7 support until Git for Windows drops support for Windows 7, but that's [not going to happen](#4996 (comment)). The next best thing we can do is to let the users know what is happening, and how to get out of their fix, at least. This is not quite as easy as it would first seem because programs compiled with Go 1.21 or newer will simply throw an exception and fail with an Access Violation on Windows 7. The only way I found to address this is to replicate the logic from Go's very own `version` command (which can determine the Go version with which a given executable was built) to detect the situation, and in that case offer a helpful error message. This addresses #4996. /cc @chrisd8088
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 10, 2024
Git LFS is now built with Go 1.21 which no longer supports Windows 7. However, Git for Windows still wants to support Windows 7. Ideally, Git LFS would re-introduce Windows 7 support until Git for Windows drops support for Windows 7, but that's [not going to happen](#4996 (comment)). The next best thing we can do is to let the users know what is happening, and how to get out of their fix, at least. This is not quite as easy as it would first seem because programs compiled with Go 1.21 or newer will simply throw an exception and fail with an Access Violation on Windows 7. The only way I found to address this is to replicate the logic from Go's very own `version` command (which can determine the Go version with which a given executable was built) to detect the situation, and in that case offer a helpful error message. This addresses #4996. /cc @chrisd8088
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 11, 2024
Git LFS is now built with Go 1.21 which no longer supports Windows 7. However, Git for Windows still wants to support Windows 7. Ideally, Git LFS would re-introduce Windows 7 support until Git for Windows drops support for Windows 7, but that's [not going to happen](#4996 (comment)). The next best thing we can do is to let the users know what is happening, and how to get out of their fix, at least. This is not quite as easy as it would first seem because programs compiled with Go 1.21 or newer will simply throw an exception and fail with an Access Violation on Windows 7. The only way I found to address this is to replicate the logic from Go's very own `version` command (which can determine the Go version with which a given executable was built) to detect the situation, and in that case offer a helpful error message. This addresses #4996. /cc @chrisd8088
dscho
added a commit
that referenced
this pull request
Jul 11, 2024
Git LFS is now built with Go 1.21 which no longer supports Windows 7. However, Git for Windows still wants to support Windows 7. Ideally, Git LFS would re-introduce Windows 7 support until Git for Windows drops support for Windows 7, but that's [not going to happen](#4996 (comment)). The next best thing we can do is to let the users know what is happening, and how to get out of their fix, at least. This is not quite as easy as it would first seem because programs compiled with Go 1.21 or newer will simply throw an exception and fail with an Access Violation on Windows 7. The only way I found to address this is to replicate the logic from Go's very own `version` command (which can determine the Go version with which a given executable was built) to detect the situation, and in that case offer a helpful error message. This addresses #4996. /cc @chrisd8088
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 11, 2024
Git LFS is now built with Go 1.21 which no longer supports Windows 7. However, Git for Windows still wants to support Windows 7. Ideally, Git LFS would re-introduce Windows 7 support until Git for Windows drops support for Windows 7, but that's [not going to happen](#4996 (comment)). The next best thing we can do is to let the users know what is happening, and how to get out of their fix, at least. This is not quite as easy as it would first seem because programs compiled with Go 1.21 or newer will simply throw an exception and fail with an Access Violation on Windows 7. The only way I found to address this is to replicate the logic from Go's very own `version` command (which can determine the Go version with which a given executable was built) to detect the situation, and in that case offer a helpful error message. This addresses #4996. /cc @chrisd8088
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 11, 2024
Git LFS is now built with Go 1.21 which no longer supports Windows 7. However, Git for Windows still wants to support Windows 7. Ideally, Git LFS would re-introduce Windows 7 support until Git for Windows drops support for Windows 7, but that's [not going to happen](#4996 (comment)). The next best thing we can do is to let the users know what is happening, and how to get out of their fix, at least. This is not quite as easy as it would first seem because programs compiled with Go 1.21 or newer will simply throw an exception and fail with an Access Violation on Windows 7. The only way I found to address this is to replicate the logic from Go's very own `version` command (which can determine the Go version with which a given executable was built) to detect the situation, and in that case offer a helpful error message. This addresses #4996. /cc @chrisd8088
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 12, 2024
Git LFS is now built with Go 1.21 which no longer supports Windows 7. However, Git for Windows still wants to support Windows 7. Ideally, Git LFS would re-introduce Windows 7 support until Git for Windows drops support for Windows 7, but that's [not going to happen](#4996 (comment)). The next best thing we can do is to let the users know what is happening, and how to get out of their fix, at least. This is not quite as easy as it would first seem because programs compiled with Go 1.21 or newer will simply throw an exception and fail with an Access Violation on Windows 7. The only way I found to address this is to replicate the logic from Go's very own `version` command (which can determine the Go version with which a given executable was built) to detect the situation, and in that case offer a helpful error message. This addresses #4996. /cc @chrisd8088
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 12, 2024
Git LFS is now built with Go 1.21 which no longer supports Windows 7. However, Git for Windows still wants to support Windows 7. Ideally, Git LFS would re-introduce Windows 7 support until Git for Windows drops support for Windows 7, but that's [not going to happen](#4996 (comment)). The next best thing we can do is to let the users know what is happening, and how to get out of their fix, at least. This is not quite as easy as it would first seem because programs compiled with Go 1.21 or newer will simply throw an exception and fail with an Access Violation on Windows 7. The only way I found to address this is to replicate the logic from Go's very own `version` command (which can determine the Go version with which a given executable was built) to detect the situation, and in that case offer a helpful error message. This addresses #4996. /cc @chrisd8088
gitforwindowshelper Bot
pushed a commit
that referenced
this pull request
Jul 15, 2026
Git for Windows dropped Windows 7 support a long time ago. There is a patch (introduced in #5042 and in #5059) to detect when Git LFS failed to start because of lack of Windows 7 support (which was lost somewhat surprisingly, via a Go upgrade that slipped that change in), and to provid a helpful message to the user in that instance. Since Git for Windows itself does not support Windows 7 anymore, that patch is no longer necessary, either.
gitforwindowshelper Bot
pushed a commit
that referenced
this pull request
Jul 15, 2026
Git for Windows dropped Windows 7 support a long time ago. There is a patch (introduced in #5042 and in #5059) to detect when Git LFS failed to start because of lack of Windows 7 support (which was lost somewhat surprisingly, via a Go upgrade that slipped that change in), and to provid a helpful message to the user in that instance. Since Git for Windows itself does not support Windows 7 anymore, that patch is no longer necessary, either.
gitforwindowshelper Bot
pushed a commit
that referenced
this pull request
Jul 15, 2026
Git for Windows dropped Windows 7 support a long time ago. There is a patch (introduced in #5042 and in #5059) to detect when Git LFS failed to start because of lack of Windows 7 support (which was lost somewhat surprisingly, via a Go upgrade that slipped that change in), and to provid a helpful message to the user in that instance. Since Git for Windows itself does not support Windows 7 anymore, that patch is no longer necessary, either.
gitforwindowshelper Bot
pushed a commit
that referenced
this pull request
Jul 16, 2026
Git for Windows dropped Windows 7 support a long time ago. There is a patch (introduced in #5042 and in #5059) to detect when Git LFS failed to start because of lack of Windows 7 support (which was lost somewhat surprisingly, via a Go upgrade that slipped that change in), and to provid a helpful message to the user in that instance. Since Git for Windows itself does not support Windows 7 anymore, that patch is no longer necessary, either.
gitforwindowshelper Bot
pushed a commit
that referenced
this pull request
Jul 16, 2026
Git for Windows dropped Windows 7 support a long time ago. There is a patch (introduced in #5042 and in #5059) to detect when Git LFS failed to start because of lack of Windows 7 support (which was lost somewhat surprisingly, via a Go upgrade that slipped that change in), and to provid a helpful message to the user in that instance. Since Git for Windows itself does not support Windows 7 anymore, that patch is no longer necessary, either.
gitforwindowshelper Bot
pushed a commit
that referenced
this pull request
Jul 16, 2026
Git for Windows dropped Windows 7 support a long time ago. There is a patch (introduced in #5042 and in #5059) to detect when Git LFS failed to start because of lack of Windows 7 support (which was lost somewhat surprisingly, via a Go upgrade that slipped that change in), and to provid a helpful message to the user in that instance. Since Git for Windows itself does not support Windows 7 anymore, that patch is no longer necessary, either.
gitforwindowshelper Bot
pushed a commit
that referenced
this pull request
Jul 17, 2026
Git for Windows dropped Windows 7 support a long time ago. There is a patch (introduced in #5042 and in #5059) to detect when Git LFS failed to start because of lack of Windows 7 support (which was lost somewhat surprisingly, via a Go upgrade that slipped that change in), and to provid a helpful message to the user in that instance. Since Git for Windows itself does not support Windows 7 anymore, that patch is no longer necessary, either.
gitforwindowshelper Bot
pushed a commit
that referenced
this pull request
Jul 17, 2026
Git for Windows dropped Windows 7 support a long time ago. There is a patch (introduced in #5042 and in #5059) to detect when Git LFS failed to start because of lack of Windows 7 support (which was lost somewhat surprisingly, via a Go upgrade that slipped that change in), and to provid a helpful message to the user in that instance. Since Git for Windows itself does not support Windows 7 anymore, that patch is no longer necessary, either.
gitforwindowshelper Bot
pushed a commit
that referenced
this pull request
Jul 17, 2026
Git for Windows dropped Windows 7 support a long time ago. There is a patch (introduced in #5042 and in #5059) to detect when Git LFS failed to start because of lack of Windows 7 support (which was lost somewhat surprisingly, via a Go upgrade that slipped that change in), and to provid a helpful message to the user in that instance. Since Git for Windows itself does not support Windows 7 anymore, that patch is no longer necessary, either.
gitforwindowshelper Bot
pushed a commit
that referenced
this pull request
Jul 17, 2026
Git for Windows dropped Windows 7 support a long time ago. There is a patch (introduced in #5042 and in #5059) to detect when Git LFS failed to start because of lack of Windows 7 support (which was lost somewhat surprisingly, via a Go upgrade that slipped that change in), and to provid a helpful message to the user in that instance. Since Git for Windows itself does not support Windows 7 anymore, that patch is no longer necessary, either.
gitforwindowshelper Bot
pushed a commit
that referenced
this pull request
Jul 19, 2026
Git for Windows dropped Windows 7 support a long time ago. There is a patch (introduced in #5042 and in #5059) to detect when Git LFS failed to start because of lack of Windows 7 support (which was lost somewhat surprisingly, via a Go upgrade that slipped that change in), and to provid a helpful message to the user in that instance. Since Git for Windows itself does not support Windows 7 anymore, that patch is no longer necessary, either.
gitforwindowshelper Bot
pushed a commit
that referenced
this pull request
Jul 19, 2026
Git for Windows dropped Windows 7 support a long time ago. There is a patch (introduced in #5042 and in #5059) to detect when Git LFS failed to start because of lack of Windows 7 support (which was lost somewhat surprisingly, via a Go upgrade that slipped that change in), and to provid a helpful message to the user in that instance. Since Git for Windows itself does not support Windows 7 anymore, that patch is no longer necessary, either.
gitforwindowshelper Bot
pushed a commit
that referenced
this pull request
Jul 19, 2026
Git for Windows dropped Windows 7 support a long time ago. There is a patch (introduced in #5042 and in #5059) to detect when Git LFS failed to start because of lack of Windows 7 support (which was lost somewhat surprisingly, via a Go upgrade that slipped that change in), and to provid a helpful message to the user in that instance. Since Git for Windows itself does not support Windows 7 anymore, that patch is no longer necessary, either.
gitforwindowshelper Bot
pushed a commit
that referenced
this pull request
Jul 19, 2026
Git for Windows dropped Windows 7 support a long time ago. There is a patch (introduced in #5042 and in #5059) to detect when Git LFS failed to start because of lack of Windows 7 support (which was lost somewhat surprisingly, via a Go upgrade that slipped that change in), and to provid a helpful message to the user in that instance. Since Git for Windows itself does not support Windows 7 anymore, that patch is no longer necessary, either.
gitforwindowshelper Bot
pushed a commit
that referenced
this pull request
Jul 20, 2026
Git for Windows dropped Windows 7 support a long time ago. There is a patch (introduced in #5042 and in #5059) to detect when Git LFS failed to start because of lack of Windows 7 support (which was lost somewhat surprisingly, via a Go upgrade that slipped that change in), and to provid a helpful message to the user in that instance. Since Git for Windows itself does not support Windows 7 anymore, that patch is no longer necessary, either.
gitforwindowshelper Bot
pushed a commit
that referenced
this pull request
Jul 20, 2026
Git for Windows dropped Windows 7 support a long time ago. There is a patch (introduced in #5042 and in #5059) to detect when Git LFS failed to start because of lack of Windows 7 support (which was lost somewhat surprisingly, via a Go upgrade that slipped that change in), and to provid a helpful message to the user in that instance. Since Git for Windows itself does not support Windows 7 anymore, that patch is no longer necessary, either.
gitforwindowshelper Bot
pushed a commit
that referenced
this pull request
Jul 21, 2026
Git for Windows dropped Windows 7 support a long time ago. There is a patch (introduced in #5042 and in #5059) to detect when Git LFS failed to start because of lack of Windows 7 support (which was lost somewhat surprisingly, via a Go upgrade that slipped that change in), and to provid a helpful message to the user in that instance. Since Git for Windows itself does not support Windows 7 anymore, that patch is no longer necessary, either.
gitforwindowshelper Bot
pushed a commit
that referenced
this pull request
Jul 21, 2026
Git for Windows dropped Windows 7 support a long time ago. There is a patch (introduced in #5042 and in #5059) to detect when Git LFS failed to start because of lack of Windows 7 support (which was lost somewhat surprisingly, via a Go upgrade that slipped that change in), and to provid a helpful message to the user in that instance. Since Git for Windows itself does not support Windows 7 anymore, that patch is no longer necessary, either.
gitforwindowshelper Bot
pushed a commit
that referenced
this pull request
Jul 22, 2026
Git for Windows dropped Windows 7 support a long time ago. There is a patch (introduced in #5042 and in #5059) to detect when Git LFS failed to start because of lack of Windows 7 support (which was lost somewhat surprisingly, via a Go upgrade that slipped that change in), and to provid a helpful message to the user in that instance. Since Git for Windows itself does not support Windows 7 anymore, that patch is no longer necessary, either.
gitforwindowshelper Bot
pushed a commit
that referenced
this pull request
Jul 22, 2026
Git for Windows dropped Windows 7 support a long time ago. There is a patch (introduced in #5042 and in #5059) to detect when Git LFS failed to start because of lack of Windows 7 support (which was lost somewhat surprisingly, via a Go upgrade that slipped that change in), and to provid a helpful message to the user in that instance. Since Git for Windows itself does not support Windows 7 anymore, that patch is no longer necessary, either.
gitforwindowshelper Bot
pushed a commit
that referenced
this pull request
Jul 22, 2026
Git for Windows dropped Windows 7 support a long time ago. There is a patch (introduced in #5042 and in #5059) to detect when Git LFS failed to start because of lack of Windows 7 support (which was lost somewhat surprisingly, via a Go upgrade that slipped that change in), and to provid a helpful message to the user in that instance. Since Git for Windows itself does not support Windows 7 anymore, that patch is no longer necessary, either.
gitforwindowshelper Bot
pushed a commit
that referenced
this pull request
Jul 23, 2026
Git for Windows dropped Windows 7 support a long time ago. There is a patch (introduced in #5042 and in #5059) to detect when Git LFS failed to start because of lack of Windows 7 support (which was lost somewhat surprisingly, via a Go upgrade that slipped that change in), and to provid a helpful message to the user in that instance. Since Git for Windows itself does not support Windows 7 anymore, that patch is no longer necessary, either.
gitforwindowshelper Bot
pushed a commit
that referenced
this pull request
Jul 23, 2026
Git for Windows dropped Windows 7 support a long time ago. There is a patch (introduced in #5042 and in #5059) to detect when Git LFS failed to start because of lack of Windows 7 support (which was lost somewhat surprisingly, via a Go upgrade that slipped that change in), and to provid a helpful message to the user in that instance. Since Git for Windows itself does not support Windows 7 anymore, that patch is no longer necessary, either.
gitforwindowshelper Bot
pushed a commit
that referenced
this pull request
Jul 23, 2026
Git for Windows dropped Windows 7 support a long time ago. There is a patch (introduced in #5042 and in #5059) to detect when Git LFS failed to start because of lack of Windows 7 support (which was lost somewhat surprisingly, via a Go upgrade that slipped that change in), and to provid a helpful message to the user in that instance. Since Git for Windows itself does not support Windows 7 anymore, that patch is no longer necessary, either.
gitforwindowshelper Bot
pushed a commit
that referenced
this pull request
Jul 23, 2026
Git for Windows dropped Windows 7 support a long time ago. There is a patch (introduced in #5042 and in #5059) to detect when Git LFS failed to start because of lack of Windows 7 support (which was lost somewhat surprisingly, via a Go upgrade that slipped that change in), and to provid a helpful message to the user in that instance. Since Git for Windows itself does not support Windows 7 anymore, that patch is no longer necessary, either.
gitforwindowshelper Bot
pushed a commit
that referenced
this pull request
Jul 24, 2026
Git for Windows dropped Windows 7 support a long time ago. There is a patch (introduced in #5042 and in #5059) to detect when Git LFS failed to start because of lack of Windows 7 support (which was lost somewhat surprisingly, via a Go upgrade that slipped that change in), and to provid a helpful message to the user in that instance. Since Git for Windows itself does not support Windows 7 anymore, that patch is no longer necessary, either.
gitforwindowshelper Bot
pushed a commit
that referenced
this pull request
Jul 25, 2026
Git for Windows dropped Windows 7 support a long time ago. There is a patch (introduced in #5042 and in #5059) to detect when Git LFS failed to start because of lack of Windows 7 support (which was lost somewhat surprisingly, via a Go upgrade that slipped that change in), and to provid a helpful message to the user in that instance. Since Git for Windows itself does not support Windows 7 anymore, that patch is no longer necessary, either.
gitforwindowshelper Bot
pushed a commit
that referenced
this pull request
Jul 25, 2026
Git for Windows dropped Windows 7 support a long time ago. There is a patch (introduced in #5042 and in #5059) to detect when Git LFS failed to start because of lack of Windows 7 support (which was lost somewhat surprisingly, via a Go upgrade that slipped that change in), and to provid a helpful message to the user in that instance. Since Git for Windows itself does not support Windows 7 anymore, that patch is no longer necessary, either.
gitforwindowshelper Bot
pushed a commit
that referenced
this pull request
Jul 26, 2026
Git for Windows dropped Windows 7 support a long time ago. There is a patch (introduced in #5042 and in #5059) to detect when Git LFS failed to start because of lack of Windows 7 support (which was lost somewhat surprisingly, via a Go upgrade that slipped that change in), and to provid a helpful message to the user in that instance. Since Git for Windows itself does not support Windows 7 anymore, that patch is no longer necessary, either.
gitforwindowshelper Bot
pushed a commit
that referenced
this pull request
Jul 26, 2026
Git for Windows dropped Windows 7 support a long time ago. There is a patch (introduced in #5042 and in #5059) to detect when Git LFS failed to start because of lack of Windows 7 support (which was lost somewhat surprisingly, via a Go upgrade that slipped that change in), and to provid a helpful message to the user in that instance. Since Git for Windows itself does not support Windows 7 anymore, that patch is no longer necessary, either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Git LFS is now built with Go 1.21 which no longer supports Windows 7. However, Git for Windows still wants to support Windows 7.
Ideally, Git LFS would re-introduce Windows 7 support until Git for Windows drops support for Windows 7, but that's not going to happen.
The next best thing we can do is to let the users know what is happening, and how to get out of their fix, at least.
This is not quite as easy as it would first seem because programs compiled with Go 1.21 or newer will simply throw an exception and fail with an Access Violation on Windows 7.
The only way I found to address this is to replicate the logic from Go's very own
versioncommand (which can determine the Go version with which a given executable was built) to detect the situation, and in that case offer a helpful error message.This addresses #4996.
/cc @chrisd8088