Skip to content

MODEL_TENSOR.SSM_DT_NORM has defined twice#14991

Merged
compilade merged 2 commits into
ggml-org:masterfrom
csabakecskemeti:fix_jamba
Jul 31, 2025
Merged

MODEL_TENSOR.SSM_DT_NORM has defined twice#14991
compilade merged 2 commits into
ggml-org:masterfrom
csabakecskemeti:fix_jamba

Conversation

@csabakecskemeti

Copy link
Copy Markdown
Contributor

MODEL_TENSOR.SSM_DT_NORM has defined twice

  1. Line 618-620 (correct for Jamba):
  MODEL_TENSOR.SSM_DT_NORM: (
      "model.layers.{bid}.mamba.dt_layernorm",  # jamba
  ),
  1. Lines 648-650 (for plamo2, overwrites the first):
  MODEL_TENSOR.SSM_DT_NORM: (
      "model.layers.layers.{bid}.mixer.dt_norm.weight",  # plamo2
  ),

This has blocked the quantization of ai21labs/AI21-Jamba-Mini-1.7

"architectures": [
"JambaForCausalLM"
],

Make sure to read the contributing guidelines before submitting a PR

@csabakecskemeti

Copy link
Copy Markdown
Contributor Author

convert_hf_to_gguf.py to f16 succeeded with AI21-Jamba-Mini-1.7

@github-actions github-actions Bot added the python python script changes label Jul 31, 2025

@compilade compilade left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment on lines -618 to -620
MODEL_TENSOR.SSM_DT_NORM: (
"model.layers.{bid}.mamba.dt_layernorm", # jamba
),

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I would have done it the other way and keep this one (since it's right near SSM_DT) instead of the other one, but it's correct like this too since the mappings are still merged.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can change it quickly

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@compilade
compilade merged commit 36e5fe7 into ggml-org:master Jul 31, 2025
4 checks passed
blime4 referenced this pull request in blime4/llama.cpp Feb 5, 2026
* MODEL_TENSOR.SSM_DT_NORM has defined twice, and second overwritten the jamba model's layername

* correct order
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
* MODEL_TENSOR.SSM_DT_NORM has defined twice, and second overwritten the jamba model's layername

* correct order
ljubomirj pushed a commit to ljubomirj/llama.cpp that referenced this pull request May 6, 2026
* MODEL_TENSOR.SSM_DT_NORM has defined twice, and second overwritten the jamba model's layername

* correct order
my-other-github-account pushed a commit to my-other-github-account/llama.cpp that referenced this pull request May 15, 2026
* MODEL_TENSOR.SSM_DT_NORM has defined twice, and second overwritten the jamba model's layername

* correct order
my-other-github-account pushed a commit to my-other-github-account/llama.cpp that referenced this pull request May 15, 2026
* MODEL_TENSOR.SSM_DT_NORM has defined twice, and second overwritten the jamba model's layername

* correct order
phibya pushed a commit to ziee-ai/llama.cpp that referenced this pull request May 29, 2026
* MODEL_TENSOR.SSM_DT_NORM has defined twice, and second overwritten the jamba model's layername

* correct order
fewtarius pushed a commit to fewtarius/CachyLLama that referenced this pull request May 30, 2026
* MODEL_TENSOR.SSM_DT_NORM has defined twice, and second overwritten the jamba model's layername

* correct order
fukuro-kun pushed a commit to fukuro-kun/fukuro-llama-cpp-turboquant that referenced this pull request Jul 5, 2026
* MODEL_TENSOR.SSM_DT_NORM has defined twice, and second overwritten the jamba model's layername

* correct order
MrLordCat referenced this pull request in MrLordCat/llama.cpp-with-GUI Jul 16, 2026
* MODEL_TENSOR.SSM_DT_NORM has defined twice, and second overwritten the jamba model's layername

* correct order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python python script changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants