Skip to content

fix(overlay): UI fixes. #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BYK merged 3 commits into from
Nov 6, 2024
Merged

fix(overlay): UI fixes. #555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
95bae2f
- Fixed condition for showing open file in editor icon on error frame.
Shubhdeep12 Nov 6, 2024
4097c1c
reverted open condition
Shubhdeep12 Nov 6, 2024
2f17087
updated changeset
Shubhdeep12 Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/big-radios-count.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@spotlightjs/overlay': patch
---

- changed route and added navigation in performance tab to make queries tab default active.
- Fixed showing of 0 in false condition in span details.
5 changes: 3 additions & 2 deletions packages/overlay/src/integrations/sentry/components/performance/PerformanceTabDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { useState } from 'react';
import { Outlet, Route, Routes } from 'react-router-dom';
import { Navigate, Outlet, Route, Routes } from 'react-router-dom';
import Tabs from '~/components/Tabs';
import { useSpotlightContext } from '~/lib/useSpotlightContext';
import { useSentrySpans } from '../../data/useSentrySpans';
Expand Down Expand Up @@ -58,7 +58,8 @@ export default function PerformanceTabDetails() {
<Route path="webvitals" element={<WebVitals />} />
<Route path="webvitals/:page" element={<WebVitalsDetail />} />
{/* Default tab */}
<Route path="*" element={<Queries showAll={showAll} />} />
<Route path="queries" element={<Queries showAll={showAll} />} />
<Route path="*" element={<Navigate to="/performance/queries" replace />} />
Comment thread
BYK marked this conversation as resolved.
</Routes>
<Outlet />
</div>
Expand Down
2 changes: 1 addition & 1 deletion packages/overlay/src/integrations/sentry/components/traces/spans/SpanDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ export default function SpanDetails({
</div>
)}

{span.children?.length && (
{(span.children?.length ?? 0) > 0 && (
<div>
<h2 className="mb-2 font-bold uppercase">Sub-tree</h2>
<SpanTree
Expand Down