Skip to content

Fix(overlay): UI and routing issues fixed #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Shubhdeep12 merged 2 commits into from
Nov 5, 2024
Merged

Fix(overlay): UI and routing issues fixed #549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
321ce1d
fix: overlay issues fixed
Shubhdeep12 Nov 5, 2024
73eeb4d
ref
Shubhdeep12 Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/late-guests-admire.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@spotlightjs/overlay': patch
---

- Fixed some conditional rendering in TraceIcon and SpanDetails which was showing 0 on UI.
- Fixed routing for query summary page by encoding the query description which can be a long text.
3 changes: 2 additions & 1 deletion packages/overlay/src/integrations/sentry/components/performance/Queries.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,8 @@ const Queries = ({ showAll }: { showAll: boolean }) => {
{queriesData.map(query => (
<tr key={query.description} className="hover:bg-primary-900">
<td className="text-primary-200 w-2/5 truncate whitespace-nowrap px-6 py-4 text-left text-sm font-medium">
<Link className="truncate hover:underline" to={`/performance/queries/${query.description}`}>
{/* Ref: https://developer.mozilla.org/en-US/docs/Web/API/Window/btoa */}
<Link className="truncate hover:underline" to={`/performance/queries/${btoa(query.description)}`}>
{query.description}
</Link>
</td>
Expand Down
5 changes: 4 additions & 1 deletion packages/overlay/src/integrations/sentry/components/performance/QuerySummary.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,11 @@ const QuerySummary = ({ showAll }: { showAll: boolean }) => {
const spans = showAll ? allSpans : localSpans;
const compareSpanInfo = COMPARATORS[sort.active] || COMPARATORS[QUERY_SUMMARY_SORT_KEYS.timeSpent];

// Ref: https://developer.mozilla.org/en-US/docs/Web/API/Window/atob
const decodedType: string = atob(type);

return spans
.filter(span => span.description === type)
.filter(span => span.description === decodedType)
.sort((a, b) => (sort.asc ? compareSpanInfo(a, b) : compareSpanInfo(b, a)));
}, [allSpans, localSpans, showAll, sort, type]);

Expand Down
2 changes: 1 addition & 1 deletion packages/overlay/src/integrations/sentry/components/traces/TraceIcon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export default function TraceIcon({ trace }: TraceIconProps) {
{dominantPlatforms.map(platform => (
<PlatformIcon key={platform} title={platform} size={21} platform={platform} />
))}
{remainingPlatforms.length && (
{remainingPlatforms.length > 0 && (
Comment thread
BYK marked this conversation as resolved.
<div
title={remainingPlatforms.join(', ')}
className="h-[21px] w-[21px] bg-black p-0.5 text-xs font-bold text-white"
Expand Down
2 changes: 1 addition & 1 deletion packages/overlay/src/integrations/sentry/components/traces/spans/SpanDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ export default function SpanDetails({
</div>
</div>

{errors.length && (
{errors.length > 0 && (
<div className="flex flex-col items-start">
<h2 className="mb-2 font-bold uppercase">Related Errors</h2>
{errors.map(event => (
Expand Down