feat: Remove truncation when stream_gen_ai_spans is enabled#6260
feat: Remove truncation when stream_gen_ai_spans is enabled#6260alexander-alderman-webb wants to merge 18 commits into
stream_gen_ai_spans is enabled#6260Conversation
stream_gen_ai_spans is enabled
Codecov Results 📊✅ 282 passed | Total: 282 | Pass Rate: 100% | Execution Time: 42.74s All tests are passing successfully. ❌ Patch coverage is 45.00%. Project has 14761 uncovered lines. Files with missing lines (10)
Generated by Codecov Action |
sentrivana
left a comment
There was a problem hiding this comment.
Nice! Two things:
- Does message truncation exclusively affect
gen_aispans currently? In other words, is it guaranteed that all spans that will become very large because of this change will be sent as v2 spans, or do we need an extra check to only lift the truncation forgen_aispans specifically? - If we remove the parametrization from the truncation tests, will we have test coverage for the "
stream_gen_ai_spans=Trueshould not truncate messages" code path?
|
I'm fine with removing the parametrization, but we should have some test coverage for the messages being there as expected, without truncation, in the |
|
Yes, that makes sense. I'll update other tests to accept two inputs messages and assert that both are present when the option is enabled (demonstrating that input truncation is disabled in this case). |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 962fd65. Configure here.

Description
Remove message popping and binary blob redaction when the experimental
stream_gen_ai_spansis enabled.Stop parametrizing truncation tests that fail when the
stream_gen_ai_spansoption is enabled.Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)