feat: add Serilog integration#4462
Merged
Merged
Conversation
Contributor
|
Flash0ver
commented
Aug 21, 2025
Flash0ver
commented
Aug 21, 2025
Flash0ver
commented
Aug 21, 2025
Merged
6 tasks
Contributor
Author
|
@sentry review |
![seer-by-sentry[bot]](https://avatars.github.com/in/801464?s=60&v=4){kind=small}
Flash0ver
marked this pull request as ready for review
August 22, 2025 00:08
|
|
||
| private void CaptureStructuredLog(IHub hub, LogEvent logEvent, string formatted, string? template) | ||
| { | ||
| var traceHeader = hub.GetTraceHeader() ?? SentryTraceHeader.Empty; |
Collaborator
There was a problem hiding this comment.
Is the ParentSpanId required in the protocol for StructuredLogging? An empty SpanId probably isn't that useful otherwise eh?
Contributor
Author
There was a problem hiding this comment.
No ... it's an optional "Default Attribute" ... the trace_id is required.
Oops ... I made this mistake in the Sentry-SDK and Microsoft.Extensions.Logging integrations, too.
I'll create a follow-up PR to fix this issue in all integrations.
Contributor
Author
There was a problem hiding this comment.
follow-up for both the SDK-Logger and the Microsoft.Extensions.Logging integration: #4565
This was referenced May 12, 2026
This was referenced May 25, 2026
This was referenced Jun 2, 2026
This was referenced Jun 19, 2026
This was referenced Jun 29, 2026
This was referenced Jul 10, 2026
This was referenced Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add
Serilogintegration to Sentry Structured Logging.Docs
Dogfooding
getsentry/symbol-collector->SymbolCollector.Server