You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @jamescrosswell, I finally managed to get linux-musl-x64 to pass the whole CI pipeline, including integration tests. :) The last remaining TODO-item is to make the Docker image available:
Is the approach with Sentry-CI-Build-Linux-musl.slnf sensible? I wish we could use NO_MOBILE=true or NO_ANDROID=true with the existing Sentry-CI-Build-Linux.slnf, but it pulls in several projects that fail to build without Android SDK:
Is the approach with Sentry-CI-Build-Linux-musl.slnf sensible? I wish we could use NO_MOBILE=true or NO_ANDROID=true with the existing Sentry-CI-Build-Linux.slnf, but it pulls in several projects that fail to build without Android SDK:
I'd say so, and I copied your approach on #4187 (which won't land anytime soon since it's blocked on sentry-native win-arm64 support but at least will be ready once that lands
Is the approach with Sentry-CI-Build-Linux-musl.slnf sensible? I wish we could use NO_MOBILE=true or NO_ANDROID=true with the existing Sentry-CI-Build-Linux.slnf, but it pulls in several projects that fail to build without Android SDK:
Yeah I think that makes sense. The names we give to these solutions are maybe what's confusing. Implicitly building musl we're trying to provide better support for SDK users deploying ASP.NET Core apps using docker containers... so no android required.
However Sentry-CI-Build-Linux.slnf is just the base solution for contributors to the Sentry SDK who are running Linux and they could well be building Android apps... so we can't really rip it out of there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds native AOT support for
linux-musl-x64:TODO:
Notes:
Close: #4127