fix: Set empty host for itms-services URL in SentryDistribution updater#8567
Open
chenj-hub wants to merge 1 commit into
Open
Conversation
chenj-hub
requested review from
NinjaLikesCheez,
itaybre,
noahsmartin,
philipphofmann and
philprime
as code owners
July 24, 2026 18:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Explicitly set components.host = "" when constructing itms-services URLs. This ensures URLComponents generates the correct URL format with an empty host component.
💡 Motivation and Context
The buildUrlForInstall() method in SentryDistribution.Updater was generating malformed itms-services URLs. Without explicitly setting the host component, URLComponents produces URLs that don't work with iOS enterprise app distribution.
The itms-services scheme requires the format:
But without setting host = "", the generated URL was malformed.
💚 How did you test it?
Manual verification: itms-services URLs now generate in the correct format