Skip to content

ref(data-collection)!: Remove sendDefaultPii#8550

Open
philprime wants to merge 2 commits into
feat/replay-data-collection-bodiesfrom
ref/remove-send-default-pii-v10
Open

ref(data-collection)!: Remove sendDefaultPii#8550
philprime wants to merge 2 commits into
feat/replay-data-collection-bodiesfrom
ref/remove-send-default-pii-v10

Conversation

@philprime

@philprime philprime commented Jul 24, 2026

Copy link
Copy Markdown
Member

📜 Description

Remove sendDefaultPii from the V10 Swift, legacy Objective-C, and SentryObjC wrapper API surfaces. V9 keeps the property and its existing behavior.

V10 dictionary configuration no longer reads sendDefaultPii, and affected V10 tests now configure automatic collection through dataCollection. The generated V10 Swift and Objective-C API manifests record the removal.

💡 Motivation and Context

V10 replaces the broad sendDefaultPii switch with granular dataCollection options. Applications migrating to V10 must configure the relevant categories through options.dataCollection, including dataCollection.userInfo for automatic user information.

This is a breaking V10-only API change and is tracked in CHANGELOG_V10.md.

This PR is stacked on #8547 because that branch updates the V10 network tracker tests and API manifests touched by the removal.

Fixes #8253

💚 How did you test it?

  • make test-ios-v10 FOR_AGENTS=true ONLY_TESTING=SentryTests/SentryOptionsTests,SentryTests/SentryOptionsTest,SentryTests/SentryClientTests,SentryTests/SentryMetricsIntegrationTests,SentryTests/SentryNetworkTrackerTests,SentryTests/SentryTraceContextTests
  • make test-ios FOR_AGENTS=true ONLY_TESTING=SentryTests/SentryOptionsTests,SentryTests/SentryOptionsTest,SentryTests/SentryClientTests,SentryTests/SentryMetricsIntegrationTests,SentryTests/SentryNetworkTrackerTests,SentryTests/SentryTraceContextTests
  • make test-macos-v10 FOR_AGENTS=true TEST_SCHEME=SentryObjCTests ONLY_TESTING=SentryObjCTests/SentryObjCOptionsTests
  • make test-macos FOR_AGENTS=true TEST_SCHEME=SentryObjCTests ONLY_TESTING=SentryObjCTests/SentryObjCOptionsTests
  • make analyze
  • make build-ios-v10 FOR_AGENTS=true
  • make generate-public-api

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed. The V10 changelog includes migration guidance.
  • I updated the wizard if needed. Not needed for this V10-only removal.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog. The breaking change is documented in CHANGELOG_V10.md.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs. V9 remains unchanged, and V10 uses dataCollection.
  • Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.
  • If I added a new public API, I also added it to the SentryObjC wrapper. No new API was added, and the removal is mirrored in the wrapper.

Remove sendDefaultPii from the V10 Swift and Objective-C API surfaces.

Keep the option available in V9 and migrate V10 coverage to dataCollection.

BREAKING CHANGE: V10 users must replace sendDefaultPii with dataCollection.

Fixes #8253
@philprime
philprime marked this pull request as ready for review July 24, 2026 07:45
@philprime philprime self-assigned this Jul 24, 2026
@philprime philprime added ready-to-merge Use this label to trigger all PR workflows run-full-ci Allows gated GitHub Action workflows to run for a labelled pull request labels Jul 24, 2026
@sentry

sentry Bot commented Jul 24, 2026

Copy link
Copy Markdown

📲 Install Builds

iOS

🔗 App Name App ID Version Configuration
SDK-Size io.sentry.sample.SDK-Size 9.23.0 (1) Release

⚙️ sentry-cocoa Build Distribution Settings

@github-actions

Copy link
Copy Markdown
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1242.21 ms 1268.94 ms 26.73 ms
Size 24.14 KiB 1.26 MiB 1.24 MiB

Baseline results on branch: feat/replay-data-collection-bodies

Startup times

Revision Plain With Sentry Diff
1810f2b 1221.13 ms 1243.72 ms 22.60 ms

App size

Revision Plain With Sentry Diff
1810f2b 24.14 KiB 1.26 MiB 1.23 MiB

@philipphofmann philipphofmann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved ready-to-merge Use this label to trigger all PR workflows run-full-ci Allows gated GitHub Action workflows to run for a labelled pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants