fix(span): avoid clang-cl C++17 constexpr warning#7
Merged
Conversation
sentry-native builds Crashpad with clang-cl and treats warnings as errors. Crashpad PR #157 added WriteAttachment() and AppendAttachment() APIs that use base::span<const uint8_t>, making client/crashpad_client.h include span.h directly. sentry_backend_crashpad.cpp includes crashpad_client.h, so this mini_chromium header now gets compiled in sentry-native's clang-cl warning policy. clang-cl diagnoses the out-of-class definition of the static constexpr span::extent member as redundant in C++17. Guard the definition to pre-C++17 language modes. The in-class declaration is sufficient in C++17 and later, while older language modes still need the separate definition.
mujacica
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix C++17 build with ClangCL and
[-Werror,-Wdeprecated-redundant-constexpr-static-def]for: