Glue: honour HidePassword on get_connection and get_connections - #10252
Open
chiruu12 wants to merge 1 commit into
Open
Glue: honour HidePassword on get_connection and get_connections#10252chiruu12 wants to merge 1 commit into
chiruu12 wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10252 +/- ##
==========================================
+ Coverage 93.32% 93.33% +0.01%
==========================================
Files 1342 1342
Lines 122702 122925 +223
==========================================
+ Hits 114508 114736 +228
+ Misses 8194 8189 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10251
HidePasswordreached the backend and was then ignored, so asking for a connection without its secret returned the secret.as_dictnow takes the flag and drops thePASSWORDentry, which is what AWS does rather than blanking the value. Both copies are redacted: the top levelConnectionPropertiesand the nestedConnection, which carries the same dict.The redaction happens on the way out, so the stored connection keeps its password and a later call without the flag still returns it.
I also dropped
hide_passwordfrom the two backend signatures. With the redaction inas_dictnothing in the backend reads it, and leaving a parameter that is never looked at is what caused this in the first place.Four tests. Two fail on the parent commit; the other two pin that the default still returns the password and that hiding it does not change what is stored.
tests/test_glue/: 296 passed, withruff format --checkandmypyclean.ruff checkreports 7 findings undermoto/glue/; the same 7 are onmasterand none are in this change.