docs: state contract requires idempotent + associative merge, not just commutative - #92
Merged
Merged
Conversation
…t commutative The whitepaper defines contract state as an idempotent commutative monoid (associative, commutative, idempotent merge), but the ContractInterface doc comment only mentioned commutativity. Align the trait docs with the whitepaper's terminology. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018gMSXHaQ2rXKGfAVWKqk11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ContractInterface's doc comment only required delta updates to be commutative, but the whitepaper defines contract state as an idempotent commutative monoid (merge must be associative, commutative, AND idempotent). Missing idempotence in the trait docs is misleading for contract authors.Approach
Align the doc comment wording with the whitepaper's terminology ("associative, commutative, and idempotent" / "idempotent commutative monoid").
Testing
Doc-comment-only change;
cargo check -p freenet-stdlib --all-featurespasses.[AI-assisted - Claude]