Use npm trusted publishing - #105
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NPM_TOKENenvironment variable from the npm release jobfraserxu/react-chartistandrelease.ymlWhy
The package now uses GitHub Actions OIDC publishing. Keeping a token reference is unnecessary and would cause the release job to attempt token-based authentication even though no repository secret is configured.
Validation
npm publishpermissionnpm run checkNote
Low Risk
CI-only change to npm publish authentication; no application runtime or package API changes.
Overview
The release workflow no longer passes
NODE_AUTH_TOKENfromsecrets.NPM_TOKENon the Publish to npm step.Publishing is expected to authenticate via npm Trusted Publishing (GitHub Actions OIDC), which aligns with the workflow’s existing
id-token: writepermission andsetup-noderegistry configuration—avoiding token-based auth when no secret is configured.Reviewed by Cursor Bugbot for commit 6ced663. Bugbot is set up for automated code reviews on this repo. Configure here.