fix(StdStorage): find short string and bytes slots - #894
Merged
grandizzy merged 3 commits intoAug 7, 2026
Conversation
stevencartavia
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse and
onbjerg
as code owners
August 6, 2026 05:56
figtracer
reviewed
Aug 6, 2026
mablr
reviewed
Aug 6, 2026
mablr
left a comment
mablr
left a comment
Member
There was a problem hiding this comment.
LGTM, just one non-blocking suggestion
mablr
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
stdStorage.find()for non-empty shortstringandbytesvalues of 1–31 bytes.The implementation matches Solidity’s short-value storage encoding and confirms the candidate slot by temporarily clearing and restoring it. Existing static, packed-slot, and
.depth()behavior remains unchanged.Fixes #345.