Rename ActionMetadata.funtion_name to function_name#7560
Conversation
|
/regen |
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
e6bd725 to
d91b2a6
Compare
pingsutw
left a comment
There was a problem hiding this comment.
Thanks, could you run make gen locally and push the change
|
The only thing keeping this red is the generated bindings: check-generate wants |
|
@SAY-5 what is /regen? what is this used for? Can't you run |
|
Understood. |
Tracking issue
Closes #7558
Why are the changes needed?
The protobuf field
ActionMetadata.funtion_nameis misspelled (missing thecin "function"). The typo is exposed through the generated stubs in every language and the publishedflyteidl2package that the Python SDK depends on, so the misspelled name leaks into public API surfaces.What changes were proposed in this pull request?
flyteidl2/workflow/run_definition.proto: rename fieldfuntion_nametofunction_name, keeping wire number13so the change is backward-compatible on the wire.runs/service/run_service.go: update the two hand-written references (actionMetadataFromModeland the metadata assignment around line 1832) fromFuntionNametoFunctionName.The
gen/stubs are generated and needmake buf, which I do not have the toolchain for locally. Per the issue's note, I'll comment/regenon this PR so CI regenerates and commits the Go/Python/TypeScript/Rust stubs.How was this patch tested?
gofmt -l runs/service/run_service.goreports no formatting issues, andgrep -rn "funtion" .returns nothing outside the still-to-be-regeneratedgen/stubs. The Go backend will build once the stubs are regenerated via/regen, sinceruns/...is the only hand-written consumer of the renamed proto symbol.Labels
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Stack
If you do use
git townto manage PR Stacks, the stack relevant to this PRwill show below. Otherwise, you can ignore this section.
Docs link