Add support for OTEL metrics - #7459
Merged
Merged
Conversation
Signed-off-by: Jason Parraga <sovietaced@gmail.com>
Signed-off-by: Jason Parraga <sovietaced@gmail.com>
Signed-off-by: Jason Parraga <sovietaced@gmail.com>
Sovietaced
marked this pull request as ready for review
May 29, 2026 23:49
Sovietaced
commented
May 29, 2026
| ) | ||
|
|
||
| const ( | ||
| AdminClientTracer = "admin-client" |
Signed-off-by: Jason Parraga <sovietaced@gmail.com>
pingsutw
approved these changes
Jun 8, 2026
3 tasks
pingsutw
added a commit
that referenced
this pull request
Jun 10, 2026
Build on the meter provider from #7459 to instrument the TaskAction controller with two metrics the framework doesn't provide: - taskaction.active (Int64ObservableGauge): number of TaskAction CRDs by plugin phase, observed asynchronously by listing from the controller cache. - taskaction.crd.size_bytes (Int64Histogram): serialized size of a TaskAction CRD, recorded per reconcile. Both are emitted via otelutils.GetMeterProvider("executor"), so they flow through the same OTLP pipeline as the RPC metrics. Registration is non-fatal (degrades to no custom metrics) and observeCRDSize is nil-safe. Reconcile rate/latency, workqueue depth, and k8s API r/w latency are already exposed by the controller-runtime metrics server; event-proxy send latency is already captured by the otelconnect-wrapped events client. Signed-off-by: Kevin Su <pingsutw@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7447
Why are the changes needed?
This pull request generally adds support for emitting OTEL metrics. Additionally, it uses
otelconnectto instrument all of the connect RPC clients/servers with OTEL metrics. Without configuration all trace/metric related calls will be a noop so this won't change the default behavior.What changes were proposed in this pull request?
How was this patch tested?
We have a variation of this running in our fork in production. It still uses plain gRPC instead of connect RPC but we have used
otelconnectin other capacities.Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Stack
If you do use
git townto manage PR Stacks, the stack relevant to this PRwill show below. Otherwise, you can ignore this section.
Docs link