Skip to content

[pigeon] Updates writeScoped and addScoped to disallow symbol-less use.#3081

Merged
auto-submit[bot] merged 5 commits into
flutter:mainfrom
tarrinneal:writeScoped
Jan 23, 2023
Merged

[pigeon] Updates writeScoped and addScoped to disallow symbol-less use.#3081
auto-submit[bot] merged 5 commits into
flutter:mainfrom
tarrinneal:writeScoped

Conversation

@tarrinneal

Copy link
Copy Markdown
Contributor

Updates writeScoped and addScoped to disallow symbol-less use.

This is a continuation of the work from 2b7c60a.

This is mainly to encourage the (more proper) use of the nest method in those situations.

@stuartmorgan-g stuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits.

Comment thread packages/pigeon/lib/generator_tools.dart Outdated
Comment thread packages/pigeon/lib/generator_tools.dart Outdated
Comment thread packages/pigeon/lib/generator_tools.dart Outdated
Comment thread packages/pigeon/lib/generator_tools.dart Outdated
Comment thread packages/pigeon/lib/java_generator.dart Outdated
@tarrinneal tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2023
@auto-submit auto-submit Bot merged commit 55294ef into flutter:main Jan 23, 2023
sybrands-place pushed a commit to sybrands-place/packages that referenced this pull request Jan 30, 2023
* main: (479 commits)
  removes raw ArrayLists (flutter#3101)
  Roll Flutter from c9affdb to 27f8ebd (15 revisions) (flutter#3098)
  [ci] Fix the new LUCI iOS build-all tasks (flutter#3099)
  [pigeon] [ObjC] Removes unused GetNullableObject function (flutter#3100)
  [pigeon] Swift host error handling (flutter#3084)
  Roll Flutter from a815ee6 to c9affdb (23 revisions) (flutter#3093)
  [ci] Enable min SDK version checks (flutter#3095)
  [pigeon] Fix C++ config handling (flutter#3094)
  [ci] Add LUCI version of iOS build-all (flutter#3096)
  [pigeon] Adds SwiftFunction annotation (flutter#2304)
  [flutter_adaptive_scaffold] Change `selectedIndex` on `standardNavigationRail` to allow null value. (flutter#3088)
  [pigeon] requires analyzer 5.2.0 (flutter#3090)
  Roll Flutter from c35efda to a815ee6 (22 revisions) (flutter#3089)
  [ci] Update legacy Flutter version tests (flutter#3087)
  Roll Flutter (stable) from 135454a to b06b8b2 (2551 revisions) (flutter#3086)
  [flutter_adaptive_scaffold] Fix leading and trailing Navigation Rail Widgets (flutter#3080)
  Roll Flutter from bd7bee0 to c35efda (24 revisions) (flutter#3085)
  [pigeon] Minor C++ output adjustments (flutter#3083)
  [pigeon] Updates writeScoped and addScoped to disallow symbol-less use. (flutter#3081)
  Roll Flutter from f33e8d3 to bd7bee0 (5 revisions) (flutter#3082)
  ...
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
…e. (flutter#3081)

* remove left over symbol-less scoped method calls

* assert to enforce no nesting with scoped

* changelog

* fix version num

* nits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: pigeon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants