Skip to content

[shared_preferences] switch to ffi/jni pigeon #12329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tarrinneal wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[shared_preferences] switch to ffi/jni pigeon #12329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2475039
jniffi
tarrinneal Aug 11, 2026
dfba55e
move configs
tarrinneal Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ Podfile.lock
Pods/
.swiftpm/
.symlinks/
*.g.o

*instrumentscli*.trace
*.cipd
Expand Down
2 changes: 2 additions & 0 deletions analysis_options.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ analyzer:
# Ignore generated files
- '**/*.pb.dart'
- '**/*.g.dart'
- '**/*.g.jni.dart'
- '**/*.g.ffi.dart'
- '**/*.mocks.dart' # Mockito @GenerateMocks

formatter:
Expand Down
4 changes: 2 additions & 2 deletions ...oid/src/main/kotlin/io/flutter/plugins/sharedpreferences/LegacySharedPreferencesPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ internal constructor(private val listEncoder: SharedPreferencesListEncoder) :
private fun setUp(messenger: BinaryMessenger, context: Context) {
preferences = context.getSharedPreferences(SHARED_PREFERENCES_NAME, Context.MODE_PRIVATE)
try {
SharedPreferencesApi.setUp(messenger, this)
SharedPreferencesApiRegistrar().register(this)
} catch (ex: Exception) {
Log.e(TAG, "Received exception while setting up SharedPreferencesPlugin", ex)
}
Expand All @@ -46,7 +46,7 @@ internal constructor(private val listEncoder: SharedPreferencesListEncoder) :
}

override fun onDetachedFromEngine(binding: FlutterPluginBinding) {
SharedPreferencesApi.setUp(binding.binaryMessenger, null)
SharedPreferencesApiRegistrar().register(null)
}

override fun setBool(key: String, value: Boolean): Boolean {
Expand Down
Loading
Loading