Skip to content

[rfw] Workaround IconData parameters must be const #10858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dcharkes wants to merge 2 commits into from
Closed

[rfw] Workaround IconData parameters must be const #10858

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
501f4cc
[rfw] Workaround `IconData` parameters must be const
dcharkes Jan 22, 2026
84ce626
Merge branch 'main' into icon-data-must-be-const
stuartmorgan-g Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/rfw/lib/src/flutter/argument_decoders.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -803,9 +803,14 @@ class ArgumentDecoders {
if (icon == null) {
return null;
}
// This constructs `IconData` at runtime, meaning it does not support
// the Flutter icon treeshaker.
return IconData(
// ignore: non_const_argument_for_const_parameter
icon,
// ignore: non_const_argument_for_const_parameter
fontFamily: source.v<String>([...key, 'fontFamily']),
// ignore: non_const_argument_for_const_parameter
matchTextDirection: source.v<bool>([...key, 'matchTextDirection']) ?? false,
);
}
Expand Down
Loading