Skip to content

Remove the --enable-serial-gc engine flag - #190310

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
jason-simmons:dart_remove_serial_gc
Jul 31, 2026
Merged

Remove the --enable-serial-gc engine flag#190310
auto-submit[bot] merged 1 commit into
flutter:masterfrom
jason-simmons:dart_remove_serial_gc

Conversation

@jason-simmons

Copy link
Copy Markdown
Member

This flag was used to experiment with Dart GC performance. But it is not actively being used and is no longer functioning as intended in Dart.

The flag was causing issues in recent Dart SDK rolls (see #190266)

This flag was used to experiment with Dart GC performance.  But it
is not actively being used and is no longer functioning as intended
in Dart.

The flag was causing issues in recent Dart SDK rolls
(see flutter#190266)
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jul 30, 2026
@github-actions github-actions Bot added the engine flutter/engine related. See also e: labels. label Jul 30, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the enable-serial-gc command-line switch, its associated configuration settings in the Dart VM initialization, and the corresponding unit test. There are no review comments, and I have no feedback to provide.

@jason-simmons jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 31, 2026
@auto-submit
auto-submit Bot added this pull request to the merge queue Jul 31, 2026
Merged via the queue into flutter:master with commit 6a509a0 Jul 31, 2026
27 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 31, 2026
copybara-service Bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 5, 2026
The failures in flutter engine tests which caused a rollback last time this was
rolled were fixed in flutter/flutter#190310

Changes:
```
> git log --format="%C(auto) %h %s" bd92e63..4838365
 https://dart.googlesource.com/test.git/+/4838365e Avoid transitive imports to package:analyzer (2712)
 https://dart.googlesource.com/test.git/+/70ac3ff4 [test] Support CLI compiler for sanitizer runtimes (2708)
 https://dart.googlesource.com/test.git/+/bdc37221 Avoid read-all permissions in dart.yml CI action (2713)
 https://dart.googlesource.com/test.git/+/a9a44427 Annotate async expectations with awaitNotRequired (2700)
 https://dart.googlesource.com/test.git/+/5fcd6f40 Remove unnecessary remote debugging flag (2705)
 https://dart.googlesource.com/test.git/+/72d6dfcc Launch browsers with redirecting files (2703)
 https://dart.googlesource.com/test.git/+/8ab38846 Disable more backgrounding features on chromium (2680)
 https://dart.googlesource.com/test.git/+/d835f706 Only print debug URL when debugging (2702)
 https://dart.googlesource.com/test.git/+/9abe202a Ignore dart2js output for successful compiles (2701)
 https://dart.googlesource.com/test.git/+/ce557ba1 Group messages with passing tests (2699)
 https://dart.googlesource.com/test.git/+/d79747cd Make workflow files more secure (2698)
 https://dart.googlesource.com/test.git/+/91ca13f0 Support DART_TEST_REPORTER environment variable (2692)
 https://dart.googlesource.com/test.git/+/dcb06ac7 Bump the github-actions group with 3 updates (2689)

```
Diff: https://dart.googlesource.com/test.git/+/bd92e633e7f05edc3301865bdc00d1ae181cb1f1..4838365e7fb3a2d0302cdbbd8330b7884f7d3c0d/
Change-Id: I19bf36546a3d85951185d70a859c24b5606e3d67
Tested: Package roll
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/530060
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Aug 9, 2026
…12401)

Manual roll Flutter from 2757a77a73df to e52f01c920ad (47 revisions)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@2757a77...e52f01c

2026-07-31 jason-simmons@users.noreply.github.com [Impeller] Execute PipelineCompileQueue jobs in the order that they were added (flutter/flutter#190262)
2026-07-31 engine-flutter-autoroll@skia.org Roll Packages from 7d17fc8 to 5351d8c (5 revisions) (flutter/flutter#190351)
2026-07-31 engine-flutter-autoroll@skia.org Roll Skia from dcbd015c9646 to 7ef86a5b0eb9 (4 revisions) (flutter/flutter#190347)
2026-07-31 jason-simmons@users.noreply.github.com [Impeller] Do not acquire an unneeded image in KHRSwapchainVK if the swapchain must be recreated due to a size change (flutter/flutter#190116)
2026-07-31 jason-simmons@users.noreply.github.com Remove the --enable-serial-gc engine flag (flutter/flutter#190310)
2026-07-31 36861262+QuncCccccc@users.noreply.github.com Migrate platform_channel_swift example to material_ui (flutter/flutter#190308)
2026-07-31 chris@bracken.jp macOS: Set static text accessibility role for read-only text fields (flutter/flutter#190330)
2026-07-31 engine-flutter-autoroll@skia.org Roll Dart SDK from 96f49fc43f59 to c3acfc2479f6 (1 revision) (flutter/flutter#190336)
2026-07-31 engine-flutter-autoroll@skia.org Roll Skia from 07f08414dd66 to dcbd015c9646 (1 revision) (flutter/flutter#190333)
2026-07-31 zhongliu88889@gmail.com [web] Autofill all AutofillGroup fields in semantics mode (flutter/flutter#187108)
2026-07-31 chris@bracken.jp iOS: Configure test task runner thread at display QoS (flutter/flutter#190283)
2026-07-31 engine-flutter-autoroll@skia.org Roll Skia from a1109355de78 to 07f08414dd66 (5 revisions) (flutter/flutter#190328)
2026-07-31 chris@bracken.jp Support reduceMotion accessibility feature in MediaQuery (flutter/flutter#190287)
2026-07-30 engine-flutter-autoroll@skia.org Roll Dart SDK from 43f7de5f4977 to 96f49fc43f59 (4 revisions) (flutter/flutter#190312)
2026-07-30 mu7ammadkamel@hotmail.com fix: text selection two handles directionality. (flutter/flutter#179928)
2026-07-30 matt.boetger@gmail.com Add java/gradle check when gradle crashes (flutter/flutter#189997)
2026-07-30 41765610+ahyangnb@users.noreply.github.com [Impeller] Add filterQuality support to ImageFilter.shader (flutter/flutter#188544)
2026-07-30 dkwingsmt@users.noreply.github.com [flutter/flutter] Migrate multiple_windows example to material_ui (flutter/flutter#190313)
2026-07-30 engine-flutter-autoroll@skia.org Roll Skia from 50cf67910462 to a1109355de78 (6 revisions) (flutter/flutter#190306)
2026-07-30 31859944+LongCatIsLooong@users.noreply.github.com Migrate swift xctests to Swift testing tests (flutter/flutter#187801)
2026-07-30 36861262+QuncCccccc@users.noreply.github.com Migrates the platform_channel example to material_ui (flutter/flutter#190253)
2026-07-30 chris@bracken.jp iOS: Drop unnecessary @mainactor from VSyncClientTests (flutter/flutter#190285)
2026-07-30 evanwall@buffalo.edu Add nullptr check to isOpaque (flutter/flutter#189796)
2026-07-30 bdero@google.com [Flutter GPU] Bind uniforms and textures by cached reflection index (flutter/flutter#189820)
2026-07-30 jmccandless@google.com Migrate layers example to material_ui (flutter/flutter#190237)
2026-07-30 bernaferrari2@gmail.com Add `ShapeBorder` hit test fast paths (flutter/flutter#187962)
2026-07-30 codefu@google.com ci: mac-must-wait part duex (flutter/flutter#190295)
2026-07-30 engine-flutter-autoroll@skia.org Roll Skia from 491301f393d1 to 50cf67910462 (3 revisions) (flutter/flutter#190294)
2026-07-30 engine-flutter-autoroll@skia.org Roll Packages from dd11626 to 7d17fc8 (1 revision) (flutter/flutter#190293)
2026-07-30 engine-flutter-autoroll@skia.org Roll Skia from 177de1940bf2 to 491301f393d1 (1 revision) (flutter/flutter#190279)
2026-07-30 engine-flutter-autoroll@skia.org Roll Skia from b8bda91f02db to 177de1940bf2 (5 revisions) (flutter/flutter#190272)
2026-07-30 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from J8rVTlBnjnUpuHYk3... to _J8wM3kyQpLN9wvRD... (flutter/flutter#190273)
2026-07-30 engine-flutter-autoroll@skia.org Roll Skia from 78afc18c9ba0 to b8bda91f02db (3 revisions) (flutter/flutter#190268)
2026-07-30 154381524+flutteractionsbot@users.noreply.github.com Revert: Split the platform and cpuArch part of TargetPlatform (flutter/flutter#190258)
2026-07-30 developeryusuf@icloud.com Return null from RenderProxyBoxMixin.computeDryBaseline when the child has no baseline (flutter/flutter#189723)
2026-07-30 engine-flutter-autoroll@skia.org Roll Skia from 6fea713d32ec to 78afc18c9ba0 (4 revisions) (flutter/flutter#190257)
2026-07-30 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#190259)
2026-07-29 brackenavaron@gmail.com [cross imports] Check examples cross imports (flutter/flutter#187662)
2026-07-29 codefu@google.com ci: mac verify binaries still has to wait on linux_host_engine (flutter/flutter#190239)
2026-07-29 30870216+gaaclarke@users.noreply.github.com Adds analytics to macos impeller opt in/out (flutter/flutter#190220)
2026-07-29 engine-flutter-autoroll@skia.org Roll Skia from 0f35bba4945c to 6fea713d32ec (6 revisions) (flutter/flutter#190230)
2026-07-29 chris@bracken.jp iOS: Fix Swift warning in TracingTests (flutter/flutter#190203)
2026-07-29 matt.boetger@gmail.com Convert all gradle-wrapper.properties in /dev to use distribution 'bin' (flutter/flutter#190226)
2026-07-29 engine-flutter-autoroll@skia.org Roll Packages from 3e63635 to dd11626 (11 revisions) (flutter/flutter#190216)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD engine flutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants