GPII-3640 minor changes to run in electron#27
Conversation
|
@sgithens, sorry for the extreme delay. The logical next step here to me is to add electron as a dev dependency and add a test that exercises the package in electron. We'd then want to work through errors related to each of the two bits you had to comment out. One (the fluid require) seems like something on the server side needs to be moved to the "common" or "client" side. No idea about the other, but tests would certainly make it clear what you're trying to do and give us a consistent error to talk about. |
|
CI job failed: https://ci.gpii.net/job/gpii-handlebars-tests/2/ |
|
@sgithens, I have been working to fix the CI config for this project. If you merge with master and commit, you should have everything you need to run tests against your work. |
|
If this is still relevant, please update to reflect current master and I promise I'll review much more quickly. |
|
|
This clearly isn't ready for merging, but opening this to document the changes I needed to make.