Regression in 1.3.10?

[ciprianmiclaus]

Release 1.3.10 (https://www.npmjs.com/package/react-popper/v/1.3.10) seems to have re-introduced an issue that was fixed in 1.3.7: #320
An infinite loop when zoom is at 75%. I can reproduce locally with 1.3.10, not with 1.3.7

[FezVrasta]

I think the only change introduced by 1.3.10 is a replacement library for the create-react-context one that didn't support React 17. I don't think it can be the issue.

[ciprianmiclaus]

Doing a diff between the index.umd.js in react-popper1.3.7 and react-popper1.3.10, I can clearly see 1.3.10 is missing the deepEqual comparison on props.modifiers (which was the fix for the infinite loop). Perhaps 1.3.10 was based on a previous version?

[FezVrasta]

Could be, my iMac hard drive is misbehaving lately, I lost 1 week of saved files the other day...

Is the v1.x branch okay?

[ciprianmiclaus]

No, it's not, it seems it was branched off 1.3.6, not 1.3.7 - that's the problem.

[FezVrasta]

🤔

[FezVrasta]

I can't find the commit, could you cherry pick it in a new branch and send a PR please?

[ciprianmiclaus]

Can you add me as a contributor?

[FezVrasta]

There's no need, fork the repository and work on the fork, then you can send a PR to merge into this one. Or just point here to the missing commit and I'll do it myself.

[ciprianmiclaus]

Here's the missing commit:
47677e9

[FezVrasta]

1.3.11 should include it

[ciprianmiclaus]

Thank you!