Dockerfile.sdk-*: Disable Portage sandboxes during all image builds#4071
Open
chewi wants to merge 1 commit into
Open
Dockerfile.sdk-*: Disable Portage sandboxes during all image builds#4071chewi wants to merge 1 commit into
chewi wants to merge 1 commit into
Conversation
In #3955, I stopped disabling these sandboxes permanently, but they still need to be disabled temporarily during all the (unprivileged) image builds, not just Dockerfile.sdk-update. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #3955, I stopped disabling these sandboxes permanently, but they still need to be disabled temporarily during all the (unprivileged) image builds, not just Dockerfile.sdk-update.
How to use
Check for
EPERMwarnings during the SDK build.Testing done
An SDK build in Jenkins made it to the packages job. I did find a single
EPERMwarning from Dockerfile.sdk-build when it breaks the dependency loops, but I stuck adeclare -p FEATURESliterally right before the emerge invocation, and it reported the expected value. It's not sudo masking the variable either. I can only guess that it's leftover state from /var/db/pkgs, which will go away with a further SDK build. One warning isn't a big deal anyway, and we were seeing a lot more than that before this change.changelog/directory (user-facing change, bug fix, security fix, update) -- N/A/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc. -- N/A