Skip to content

Bump the Gecko profile version to make sure that the Text and Log marker changes are picked up in the frontends - #6252

Merged
canova merged 1 commit into
firefox-devtools:mainfrom
canova:push-lwpuyvllttmt
Aug 10, 2026
Merged

Bump the Gecko profile version to make sure that the Text and Log marker changes are picked up in the frontends#6252
canova merged 1 commit into
firefox-devtools:mainfrom
canova:push-lwpuyvllttmt

Conversation

@canova

@canova canova commented Aug 10, 2026

Copy link
Copy Markdown
Member

Main | Deploy preview

The Text marker's name and the Log marker's message are unique strings now, so their payloads hold a string table index instead of the text.

But we realized that the frontend had some hardcoded assumptions about these marker types, and they weren't looking at the schema at all. That's fixed in #6247.

There is nothing to upgrade because the frontend reads the field format from the marker schema. But since older frontends read these two fields directly, this bump makes sure that they get updated.

Bugzilla bug: https://bugzilla.mozilla.org/show_bug.cgi?id=2054010

@canova
canova requested review from fatadel and mstange August 10, 2026 15:41
@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.73%. Comparing base (1198e50) to head (14354b6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6252   +/-   ##
=======================================
  Coverage   83.73%   83.73%           
=======================================
  Files         350      350           
  Lines       37523    37524    +1     
  Branches    10543    10538    -5     
=======================================
+ Hits        31420    31421    +1     
  Misses       5676     5676           
  Partials      427      427           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fatadel fatadel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: The text in src/profile-logic/gecko-profile-versioning.ts very much resembles the text in docs-developer/CHANGELOG-formats.md. Feels like either could be shortened.

…ker changes are picked up in the frontends

The Text marker's `name` and the Log marker's `message` are unique
strings now, so their payloads hold a string table index instead of the
text.

But we realized that the frontend had some hardcoded assumptions about
these marker types, and they weren't looking at the schema at all.
That's fixed in firefox-devtools#6247.

There is nothing to upgrade because the frontend reads the field format
from the marker schema. But since older frontends read these two fields
directly, this bump makes sure that they get updated.

Bugzilla bug: https://bugzilla.mozilla.org/show_bug.cgi?id=2054010
@canova
canova force-pushed the push-lwpuyvllttmt branch from de250db to 14354b6 Compare August 10, 2026 16:38
@canova
canova merged commit 743b086 into firefox-devtools:main Aug 10, 2026
23 checks passed
@canova canova mentioned this pull request Aug 10, 2026
canova added a commit that referenced this pull request Aug 10, 2026
Changes:

[fatadel] Create the Network track from the timeline-network schema
display location (#6224)
[Markus Stange] Only call `getRawFrameTableBuilderWithExistingContents`
once per symbolication batch. (#6233)
[fatadel] Improve discoverability of downloading a local profile (#6216)
[Nazım Can Altınova] Handle the cli daemon startup failures more
gracefully with better errors (#6241)
[Nazım Can Altınova] Add the ability to apply source maps from the CLI
(#6229)
[Nazım Can Altınova] Handle Text and Log marker payloads with their
marker schema (#6247)
[Nazım Can Altınova] Bump the Gecko profile version to make sure that
the Text and Log marker changes are picked up in the frontends (#6252)
[fatadel] Deactivate a menu button as soon as its panel is dismissed
(#6251)
[Nazım Can Altınova] 🔃 Sync: l10n -> main (August 10, 2026) (#6253)
[Nazım Can Altınova] Bump profiler-cli version to 0.8.0 (#6254)

And special thanks to our localizers:

de: Ger
de: Michael Köhler
el: George kitsoukakis
en-CA: chutten
en-CA: Saurabh
en-GB: Ian Neal
es-CL: ravmn
fy-NL, nl: Fjoerfoks
fr: Théo Chevalier
fy-NL: Fjoerfoks
ia: Melo46
it: Francesco Lodolo [:flod]
nl: Fjoerfoks
ru: michellemelsspam
ru: Valery Ledovskoy
tr: giray
tr: Selim Şumlu
zh-TW: Pin-guang Chen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants