Fix HypreADS for fieldsplit - #5328
Conversation
|
I am still playing around with this, but I think I have a nice improvement to |
pbrubeck
left a comment
There was a problem hiding this comment.
Could the same fix be applied to hypre_ams.py and bddc.py?
|
I'm about to go on holiday for a week. @pbrubeck you are very welcome to get this over the line. I can fix those other files when I get back but a user is keen to have this fixed so I see no reason to wait. |
Co-authored-by: Pablo Brubeck <brubeck@protonmail.com>
We don't have to wait, the extension to the other files was trival. |
Closes #5327
The issue was that
V.reconstruct(element=myelem), whereVis an indexed function space, was failing to reconstruct the parent space usingmyelembecause it wasn't a mixed element. I thinkreconstructis ambiguous for indexed function spaces and should be disallowed. In this case the fix is to drop all parent information by callingcollapse().Feedback on the choice of test is welcome. This was simply lifted from the issue.