Grammar Errors in README.md - #192
Closed
aarongill99 wants to merge 2 commits into
Closed
Conversation
Safari rewraps a Javascript function for each call. This means that removeEventListener will never remove a listener set by addEventListener. Use a sequence to set the eventId in the __fb_event_id property on the Javascript object so that we'll be able to see it when the object is passed in. Unfortunately, this requires removing the const flag on getEventId.
Stable Event IDs for Safari
Member
|
First, this doesn't seem to have the fix that you indicate that it has. Second, it does have a bunch of changes which are frankly dangerous because they encourage you to call NPObject calls from multiple threads (and are useless otherwise) which is a bad idea. Finally, nobody really uses NPAPI anymore anyway, so it's not really worth discussing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Grammar Errors