Conversation
|
Task linked: CU-869evmf82 Update Readme's docker section |
Closed
Collaborator
Author
|
@handlebors try |
This comment has been minimized.
This comment has been minimized.
handlebors-ferrocene Bot
pushed a commit
that referenced
this pull request
Sep 16, 2026
…tion_Ernesto-Miguez, r=<try> CU 869evmf82 Update Readmes docker section Ernesto Miguez
emig
marked this pull request as ready for review
September 16, 2026 19:09
Hoverbear
reviewed
Sep 16, 2026
| # This example copies the downloaded packages and lists them | ||
| FROM ubuntu AS example1 | ||
|
|
||
| COPY --from=base /root/.cache/criticalup/artifacts artifacts |
Member
There was a problem hiding this comment.
Why would the user use two separate images for this? Why not just download criticalup and do the install step in their own image? I don't understand what the goal of this is, it seems to be over-engineering a simple problem?
emig
force-pushed
the
CU-869evmf82_Update-Readmes-docker-section_Ernesto-Miguez
branch
from
September 16, 2026 19:39
5c8b288 to
6ef53ed
Compare
emig
changed the title
emig
changed the title
Hoverbear
approved these changes
Sep 18, 2026
Hoverbear
left a comment
Hoverbear
left a comment
Member
There was a problem hiding this comment.
I guess we plan to add docs how to use this with Docker later? We did already basically work it out...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- docs: add example dockerfile to documentation