fix: Use join keys instead of entity names in ODFV materialization#6645
Open
anshishrivastava wants to merge 2 commits into
Open
fix: Use join keys instead of entity names in ODFV materialization#6645anshishrivastava wants to merge 2 commits into
anshishrivastava wants to merge 2 commits into
Conversation
_materialize_odfv used FeatureView.entities (entity names) instead of FeatureView.join_keys (actual join key column names) when building the entity DataFrame and querying the offline store during ODFV materialization. When an Entity's name differs from its join_keys (a supported, documented pattern), this caused materialization to query for a nonexistent column, breaking materialize()/materialize_incremental() for any OnDemandFeatureView with write_to_online_store=True sourced from such a feature view. Fixes feast-dev#5965 Signed-off-by: Anshi Shrivastava <anshi4shrivastava@gmail.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6645 +/- ##
==========================================
+ Coverage 45.88% 46.09% +0.21%
==========================================
Files 414 414
Lines 49950 49950
Branches 7140 7140
==========================================
+ Hits 22918 23024 +106
+ Misses 25431 25302 -129
- Partials 1601 1624 +23
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Signed-off-by: Anshi Shrivastava <anshi4shrivastava@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
_materialize_odfvusedFeatureView.entities(entity names) instead ofFeatureView.join_keys(actual join key column names) when building theentity DataFrame and querying the offline store during ODFV materialization.
When an
Entity'snamediffers from itsjoin_keys(a supported, documentedpattern), this caused materialization to query for a nonexistent column,
breaking
materialize()/materialize_incremental()for anyOnDemandFeatureView with
write_to_online_store=Truesourced from such afeature view.
This fixes both call sites in
_materialize_odfvto usesource_fv.join_keysinstead of
source_fv.entities.Which issue(s) this PR fixes:
Fixes #5965
Checks
git commit -s)Testing Strategy
Misc
Added a regression test (
test_materialize_incremental_odfv_entity_name_differs_from_join_keyin
sdk/python/tests/unit/local_feast_tests/test_local_feature_store.py) withan
Entitywhosenamediffers from itsjoin_keys. Confirmed it fails onmaster and passes with this fix.