The read offline button isn't showing after sync

[fboucher]

There's plenty of post to read. They're all available online, and I see all of them.So while connected to the network to internet I did the sync the sync pop-up show successful, but none of the button that let me open the offline text is visible.

One feature that could be very interesting to have the feeling that something is happening during the sync is have some kind of progress bar that shows us that the sync process is downloading the text version to save them locally. Poor percentage or like a progress bar saying like three done of five or something like that

[github-actions]

This was generated by AI during triage.

Triage Notes

Category: type:bug (with a secondary feature suggestion — see below)

What I established from the code:

• The "offline text" control is the "Read post" (book) button on each row of the Posts page. It only renders when the post's HTML is confirmed cached on-device (checked against the local HTML store).
• During sync, HTML is only downloaded for unread posts; cached HTML for read posts is pruned. A sync that "succeeds" can therefore still end with zero HTML cached.
• Sync reports success even if individual HTML downloads fail — those failures are only logged as warnings and do not surface to the UI.
• There is a potential ID mismatch: HTML is cached under the post's Id (falling back to RowKey), but the button checks RowKey. If these two differ for a post, the button will never show even though the HTML was downloaded.

Questions for the reporter:

1. Which platform are you on (Android, iOS, Windows, Web)? And which app version/build?
2. When you synced, were the posts unread or already read? (Read posts intentionally do not get cached HTML.)
3. Does the "Read post" book button ever appear — e.g., right after adding a brand-new unread post and syncing?
4. Can you reproduce consistently, or is it intermittent?
5. If possible, grab app logs around a sync (the sync step logs Failed to download HTML for post ...) and share them.

Feature suggestion (progress bar during sync): valid idea, but a separate concern from this bug. It should be tracked as its own feature issue with decisions about placement and what the progress reflects (posts synced vs. HTML downloaded). Please file it separately so it can be sized independently.

If you can answer the questions above, we can move this from research to an implementable bug fix.

[fboucher]

1. Android, app v1.3.2
2. All post are unread.
3. I saw the button before, not sure why right now they aren't there. Plus when I'm in the webbrowser version all buttons are present.
4. It's always not showing.
5. Added some log in notebookmark-api_logs.txt those are the log of the API.

notebookmark-api_logs.txt

[fboucher-os]

Triage Summary & Root Cause Analysis

Thank you @fboucher for providing the platform details (Android v1.3.2) and confirming all posts are unread!

Root Cause Identified: Id vs RowKey Mismatch in Offline HTML Caching

1. Storage Key Mismatch:

   • In SyncService.cs (SyncHtmlAsync), post HTML files are saved to local storage using post.Id ?? post.RowKey (e.g. SavePostHtmlAsync("123", html) creates 123.html).
   • In Posts.razor (line 45), the UI checks: localHtmlCache.IsHtmlCached(context!.RowKey).
   • When a post has a distinct Id (e.g. Id = "123" vs RowKey = "post-123"), IsHtmlCached checks for post-123.html which doesn't exist, even though 123.html was successfully downloaded and cached.
   • Consequently, the "Read post" (book) button is never rendered on Android.

2. Why it works on Web (NoteBookmark.BlazorApp):

   • Web uses AlwaysAvailableHtmlCache, which unconditionally returns true regardless of the key passed, masking the key mismatch.

3. Navigation & Reader Key:

   • Posts.razor passes context!.RowKey to ReadPost, whereas PostReader.razor calls GetPostHtmlAsync(PostId). Standardising key selection (context!.Id ?? context!.RowKey) across both IsHtmlCached and ReadPost ensures PostReader retrieves the cached HTML properly.

Action Plan & Proposed Fix:

• Update Posts.razor line 45 & 47 to use context!.Id ?? context!.RowKey instead of context!.RowKey.
• Update ILocalHtmlCache / LocalHtmlStorageService if necessary to fallback between Id and RowKey to ensure robust lookups.

Status updated to go:yes (ready to implement).