Skip to content

chore: replace mocha and chai with tap - #123

Merged
Uzlopak merged 8 commits into
masterfrom
use-tap
Sep 28, 2023
Merged

Uzlopak merged 8 commits into
masterfrom
use-tap

Conversation

@Uzlopak

@Uzlopak Uzlopak commented Aug 23, 2023

Copy link
Copy Markdown
Contributor

Checklist

@Uzlopak Uzlopak mentioned this pull request Aug 24, 2023
4 tasks done
@Uzlopak
Uzlopak marked this pull request as ready for review August 24, 2023 10:05
@Uzlopak
Uzlopak requested a review from kibertoad August 24, 2023 10:05
@gurgunday

Copy link
Copy Markdown
Member

It all LGTM, will just test it with my changes

Comment thread test/types-multipart.test.js Outdated
Co-authored-by: Gürgün Dayıoğlu <gurgun.dayioglu@icloud.com>
@gurgunday

Copy link
Copy Markdown
Member

Maybe we can merge this next

@Eomm Eomm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a conflict

@Uzlopak

Uzlopak commented Sep 28, 2023

Copy link
Copy Markdown
Contributor Author

@kibertoad
@Eomm
@gurgunday

PTAL

@gurgunday gurgunday left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Uzlopak
Uzlopak merged commit be5e0b0 into master Sep 28, 2023
@Uzlopak
Uzlopak deleted the use-tap branch September 28, 2023 14:59
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants