Skip to content

Database: Expand to full path for lmdb file location#585

Merged
h4sh3d merged 1 commit into
farcaster-project:mainfrom
sedited:databaseExpandPath
Jul 22, 2022
Merged

Database: Expand to full path for lmdb file location#585
h4sh3d merged 1 commit into
farcaster-project:mainfrom
sedited:databaseExpandPath

Conversation

@sedited

@sedited sedited commented Jul 22, 2022

Copy link
Copy Markdown
Contributor

The rust LMDB crate expects a full path for the location of the database directory.

This fixes an error where if the data_dir has a non-expanded (tilde) path, for example when running the farcaster node after a cargo install, LMDB will not be able to create a database.

Fixes #576

The rust LMDB crate expects a full path for the location of the database
directory.

This fixes an error where if the data_dir has a non-expanded (tilde)
path, for example when running the farcaster node after a cargo install,
LMDB will not be able to create a database.
@codecov-commenter

codecov-commenter commented Jul 22, 2022

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 11.9%. Comparing base (57177d1) to head (cd86d82).
⚠️ Report is 1237 commits behind head on main.

Files with missing lines Patch % Lines
src/databased/opts.rs 0.0% 3 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #585     +/-   ##
=======================================
- Coverage   11.9%   11.9%   -0.0%     
=======================================
  Files         34      34             
  Lines      10732   10735      +3     
=======================================
  Hits        1282    1282             
- Misses      9450    9453      +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@h4sh3d h4sh3d merged commit 8838b68 into farcaster-project:main Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Databased crashes on start

4 participants