Skip to content

fix(theme-translations): add missing Vietnamese translations - #10507

Merged
slorber merged 2 commits into
facebook:mainfrom
namnguyenthanhwork:patch-5
Sep 19, 2024
Merged

fix(theme-translations): add missing Vietnamese translations#10507
slorber merged 2 commits into
facebook:mainfrom
namnguyenthanhwork:patch-5

Conversation

@namnguyenthanhwork

@namnguyenthanhwork namnguyenthanhwork commented Sep 18, 2024

Copy link
Copy Markdown
Contributor

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@netlify

netlify Bot commented Sep 18, 2024

Copy link
Copy Markdown

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 9fa2774
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/66ec0c41d810780008688b43
😎 Deploy Preview https://deploy-preview-10507--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions

github-actions Bot commented Sep 18, 2024

Copy link
Copy Markdown

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🟠 76 🟢 98 🟢 96 🟢 100 Report
/docs/installation 🟠 58 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 74 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 64 🟢 96 🟢 100 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🔴 47 🟢 92 🟢 100 🟢 100 Report
/blog/tags/release 🟠 64 🟢 96 🟢 100 🟠 86 Report
/blog/tags 🟠 72 🟢 100 🟢 100 🟠 86 Report

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Sep 19, 2024
@slorber slorber changed the title chore(theme-translations): complete Vietnamese translations fix(theme-translations): add missing Vietnamese translations Sep 19, 2024

@slorber slorber left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but it's probably better if your translations have the same capitalization than the one from the base language (english)

Comment thread packages/docusaurus-theme-translations/locales/vi/theme-common.json Outdated
Comment thread packages/docusaurus-theme-translations/locales/vi/theme-common.json Outdated
@slorber

slorber commented Sep 19, 2024

Copy link
Copy Markdown
Collaborator

thanks 👍

@slorber
slorber merged commit ce159b1 into facebook:main Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants