Skip to content

chore(deps): align workspace on vite 8#3859

Merged
cixzhang merged 1 commit into
facebook:mainfrom
Han5991:chore/vite-8-alignment
Jul 12, 2026
Merged

chore(deps): align workspace on vite 8#3859
cixzhang merged 1 commit into
facebook:mainfrom
Han5991:chore/vite-8-alignment

Conversation

@Han5991

@Han5991 Han5991 commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Summary

Final step of the incremental vite migration: with vitest 2→4 (#3850) and the single-vite-7 catalog (#3847) landed, align the whole workspace on vite 8.

  • catalog: vite: ^7.3.6^8.1.3 — 8.1.4 is still inside the 7-day minimumReleaseAge window, so ^8.1.3 is the newest installable pin. The workspace consumers (root test config, packages/build's peer) move together.
  • root @vitejs/plugin-react ^4.3.0 → ^5.2.0 — 4.x peers stop at vite 7; 5.2.0 supports vite ^4–^8 with an unchanged default API. plugin-react 6 is vite-8-only and adds a react-compiler peer, so it's left as a follow-up.
  • standalone apps pinned by handapps/example-vite, apps/example-vite-tailwind (workspace-excluded templates since fix(deps): align workspace on single vite 7, drop vite override #3847) and internal/vibe-tests/app now pin vite ^8.1.3 + plugin-react ^5.2.0, a peer-coherent pair for standalone installs. The catalog bump can't reach them.
  • packages/build keeps "vite": "catalog:" as its peer — storybook and sandbox still depend on it in-workspace, and a floating peer range is how the two-vite split fixed in fix(deps): align workspace on single vite 7, drop vite override #3847 originally happened. Note this narrows the published peer to ^8.1.3 on the next release; widening it back (e.g. ^7 || ^8 anchored by a catalog devDependency) is a separate decision if vite 7 consumers need support.

Verification

  • Lockfile resolves exactly one vite: 8.1.3 (no 6.x/7.x remnants); @vitejs/plugin-react@5.2.0 resolved against it. pnpm peers check shows only the two pre-existing issues (mcp-handler, unplugin 3), unchanged from before.
  • apps/storybook tsc --noEmit passes — the surface that broke during the original vite 6/8 split (Plugin/HotUpdate type mismatch).
  • Full storybook build succeeds on vite 8's rolldown pipeline.
  • Root vitest suite: 333 files / 6247 tests green. Docsite suite: 16 files / 217 tests green. packages/build builds.
  • vibe-tests preview:build fails, but identically on main with vite 7 (unresolvable ../tailwind.css import and an alias pointing at the packages/themes/neutral/src directory) — verified against a clean main worktree; pre-existing, not a vite 8 regression.

With vitest 2->4 (facebook#3850) and the single-vite-7 catalog (facebook#3847) landed,
the remaining vite 8 step is a version alignment:

- catalog: vite ^7.3.6 -> ^8.1.3 (8.1.4 is still inside the 7-day
  minimumReleaseAge window)
- root @vitejs/plugin-react ^4.3.0 -> ^5.2.0: 4.x peers stop at vite 7,
  5.2.0 supports vite ^4-^8. plugin-react 6 is vite-8-only and adds a
  react-compiler peer, so it is left for a follow-up.
- the standalone example apps and the vibe-tests preview app pin
  vite ^8.1.3 + plugin-react ^5.2.0 by hand — they live outside the
  workspace, so the catalog bump does not reach them
- packages/build keeps "vite": "catalog:" as its peer (storybook and
  sandbox still depend on it in-workspace; a floating peer range is how
  the two-vite split of 2e64c59 happened), which narrows its published
  peer to ^8.1.3 on the next release

Verified: exactly one vite (8.1.3) in the lockfile; storybook tsc and a
full storybook build on rolldown; root (6247 tests) and docsite (217)
suites green; packages/build builds. vibe-tests preview:build fails
identically on main with vite 7 (missing tailwind.css import and a
directory alias) — pre-existing, not a vite 8 regression.
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jul 12, 2026
@vercel

vercel Bot commented Jul 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
astryx Ready Ready Preview, Comment Jul 12, 2026 4:05am

Request Review

@github-actions github-actions Bot added community Authored by a community contributor (not on the eng/design team) needs:code-review High-risk change (new package/component/API) — needs human code review before merge labels Jul 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR Analysis Report

No new or modified components detected.

Bundle Size Summary

Package Size (ESM) Size (CJS) Gzipped
@astryxdesign/core N/A 4.6KB 0B

Accessibility Audit

Status: No accessibility violations detected.


Generated by PR Enrichment workflow | View full report

@github-actions github-actions Bot removed the needs:code-review High-risk change (new package/component/API) — needs human code review before merge label Jul 12, 2026
@cixzhang
cixzhang merged commit c92e398 into facebook:main Jul 12, 2026
18 checks passed
@Han5991
Han5991 deleted the chore/vite-8-alignment branch July 12, 2026 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot. community Authored by a community contributor (not on the eng/design team)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants