Simple struct based domain#3232
Merged
Merged
Conversation
|
You are modifying libf3d public API! |
Member
Author
|
\ci fast |
mwestphal
force-pushed
the
options_domain_struct
branch
3 times, most recently
from
June 18, 2026 05:43
6135506 to
39b547a
Compare
mwestphal
commented
Jun 18, 2026
mwestphal
commented
Jun 18, 2026
mwestphal
commented
Jun 18, 2026
mwestphal
commented
Jun 18, 2026
mwestphal
commented
Jun 18, 2026
mwestphal
marked this pull request as ready for review
June 18, 2026 19:16
mwestphal
marked this pull request as draft
June 18, 2026 19:16
mwestphal
commented
Jun 21, 2026
mwestphal
commented
Jun 21, 2026
mwestphal
force-pushed
the
options_domain_struct
branch
from
June 21, 2026 13:40
8790656 to
7c543e3
Compare
mwestphal
commented
Jun 21, 2026
mwestphal
commented
Jun 21, 2026
mwestphal
force-pushed
the
options_domain_struct
branch
from
July 1, 2026 11:18
143858d to
e606442
Compare
Meakk
requested changes
Jul 1, 2026
Meakk
left a comment
Member
There was a problem hiding this comment.
some suggestions about ranges of some options.
base_ior range is a request, not a suggestion.
Member
Author
I definitely trust you there, no worries. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
options::hasDomain,options::getDomainStyle,options::getEnumDomain,options::increase,options::decrease,options::cycleincreaseanddecreasecommands for range domain optionscyclecommands for enum domain optionscycle_andincrease_commands to useincreaseandcyclewhenever possibleJson syntax:
Added Domain list:
render.effect.blending.mode: donerender.effect.antialiasing.mode: donemodel.point_sprites.type: doneinteractor.style: donerender.light.intensity: done, but implementation is different (percentage)model.color.opacity: done, but implementation is different (start from min/max)scene.animation.speed_factor: donescene.camera.index: donerender.line_width: donerender.point_size: donerender.backface_type: donerender.raytracing.samples: donerender.background.blur.coc: doneui.backdrop.opacity: doneui.scale: donemodel.normal.scale: donemodel.material.metallic: donemodel.material.roughness: donemodel.material.base_ior: donemodel.scivis.discretization: donemodel.point_sprites.size: donemodel.normal_glyphs.scale: doneTODO:
Issue ticket number and link if any
Fix #2334
Checklist for finalizing the PR
.github/workflows/versions.json, I have updateddocker_timestampAI Disclosure
Continuous integration
Please write a comment to run CI, eg:
\ci fast.See here for more info.