[build-tools] Port Maestro Tests bash step to TypeScript#3641
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 28, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3641 +/- ##
==========================================
+ Coverage 55.83% 55.97% +0.14%
==========================================
Files 864 866 +2
Lines 37170 37312 +142
Branches 7721 7759 +38
==========================================
+ Hits 20751 20882 +131
- Misses 16323 16334 +11
Partials 96 96 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hSATAC
force-pushed
the
ash/eng-19927-port-bash-maestro-step-to-typescript
branch
from
a89b35a to
9806cfe
Compare
|
Subscribed to pull request
Generated by CodeMention |
sjchmiela
approved these changes
Apr 29, 2026
sjchmiela
reviewed
Apr 29, 2026
sjchmiela
reviewed
Apr 29, 2026
Replace the bash shellscript step (defined in www/WorkflowMaestroTestJob) with a typed BuildFunction. Behaviorally identical to the bash version: runs maestro with the full flow_paths set, retries the whole set on failure, copies the latest attempt's JUnit XML to final_report_path. Smart retry (only re-running failed flows) is added in a follow-up PR. Signed-off-by: Ash Wu <hsatac@gmail.com>
hSATAC
force-pushed
the
ash/eng-19927-port-bash-maestro-step-to-typescript
branch
from
9806cfe to
9d16d62
Compare
Signed-off-by: Ash Wu <hsatac@gmail.com>
hSATAC
force-pushed
the
ash/eng-19927-port-bash-maestro-step-to-typescript
branch
from
9d16d62 to
b3f6380
Compare
Signed-off-by: Ash Wu <hsatac@gmail.com>
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Maestro test execution currently lives as an inline bash shellscript step in
WorkflowMaestroTestJob(universe). Porting to a typed build function gives us type checking, unit tests, and a base for smart retry (next PR in the stack), which is painful to express in bash.Linear: ENG-19927.
How
New
eas/run_maestro_testsbuild function with behavior identical to the bash version: runsmaestro test ...with the full input flow set, retries the whole set on failure, copies the latest attempt's JUnit XML tofinal_report_path. Adds a smallparseMaestroResults/parseJUnitFilehelper shared witheas/report_maestro_test_results.Universe-side wiring (replacing the bash step with
uses: eas/run_maestro_tests) is a separate PR.Test Plan
runMaestroTests.test.tscovering single-attempt success, retry-on-failure, attempt-N JUnit naming, copy-latest behavior, env propagation, error paths.