Merge Gate not working

[tomuben]

Checklist

In order to improve the time, how long a bugfix does take, please make sure you address as much as possible of the following checklist.

• I have reproduced the issue with at least the latest released version of <PROJECT-NAME>.
• I have added references to issues that sound similar in section Related Issues.

Tip: Adding screenshots, outputs and logs might help to improve clarity.

Summary

Merge Gate Github workflow job not working as expected.

Reproducing the Issue

Reproducibility: always

Steps to reproduce the behavior:

1.Build the Github workflows from the PTB templates
2. Make a job which is in the needs list of the merge gate fail (see here)
3. Observe

Expected Behaviour

If a dependent job (e.g. an integration test, lint check, etc.) fails, the Merge Gate should prohibit merging the "PR".

Actual Behaviour

It's possible to merge the PR, even if a dependent job failed. ("Squash Merge" button appears).
This is because the "Merge Gate" job will be skipped.

Root Cause (optional)

Looks like Github is not working according to it's documentation, see
See https://github.com/orgs/community/discussions/80788

Context

Whenever a dependent job fails, the Merge Gate job will be skipped, and not marked as failed. For Github a skipped job will be treated as succeeded, if the job is part of the branch protection rules.

Additional Context (optional)

Related Issues (optional)

In AI-lab we fixed it here