Repository navigation
build: fix aarch64-darwin build - #280
Merged
Merged
Conversation
- ioctl request arg is c_ulong on BSD; cast TIOCEXCL/TIOCGPGRP with `as _` so the i32 constants coerce to u64 on Darwin (matches the existing TIOCSCTTY site). - libotf's meta.platforms excludes Darwin; move it to the Linux-only buildInputs branch. Text shaping on macOS is covered by harfbuzz. - xtask fresh-build re-signs patched binaries with `codesign` on macOS, which isn't in the Nix sandbox PATH. Add darwin.sigtool to nativeBuildInputs — it ships a codesign shim that handles ad-hoc `--sign -` signing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as _so the i32 constants coerce to u64 on Darwin (matches the existing TIOCSCTTY site).codesignon macOS, which isn't in the Nix sandbox PATH. Add darwin.sigtool to nativeBuildInputs — it ships a codesign shim that handles ad-hoc--sign -signing.