Repository navigation
fix(backtrace): quit from recursive edits - #277
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Backtrace buffers enter a recursive edit. Invoking
top-levelto quit them is currently caught by every nested command loop, so the recursive edit restarts instead of unwinding. This leaves the backtrace buffer effectively unquittable and prevents surrounding cleanup from running.Solution
top-levelonly in the outermost command loop.top-levelso their unwind cleanup runs.Verification
git diff --check upstream/main...HEADpasses.neovm-core/src/emacs_core/eval_test.rs.neovm-coretest compilation is currently blocked on unmodifiedupstream/mainby the separate Unix-signal issue addressed in fix(windows): gate Unix signal handlers #276.