Skip to content

Fix mode-line face realization - #267

Merged
eval-exec merged 1 commit into
mainfrom
agent/fix-mode-line-face-realization
Aug 19, 2026
Merged

eval-exec merged 1 commit into
mainfrom
agent/fix-mode-line-face-realization

Conversation

@eval-exec

Copy link
Copy Markdown
Owner

What changed

  • use the canonical BasicFaceId::name() mapping for active and inactive window chrome
  • realize buffer-sensitive basic faces over the frame default, while preserving direct and inherited face remaps
  • encode that distinction as WindowNamedOverFrameDefault
  • add renderer-level regressions for active-face decorations and Treemacs-style buffer-local text scaling

Why

Selected mode lines were sometimes realized as the mode-line parent instead of mode-line-active, which leaked parent decorations and metrics. Separately, a buffer-local default scale—such as treemacs-text-scale—was incorrectly used as the base for inactive mode-line realization, shrinking window chrome along with buffer text.

GNU Emacs realizes each typed basic face from its canonical name and starts window-named realization from the frame's unremapped default. This change follows that boundary while retaining legitimate named face remappings.

Impact

  • active mode lines honor mode-line-active attributes, including explicit decoration suppression
  • Treemacs and similarly scaled buffers keep normal-sized mode-line text
  • body text remains buffer-locally scaled

Validation

  • test-first renderer-level regressions
  • GNU Emacs 31 private-X11 oracle: main and Treemacs-like mode lines both 23 px
  • rebuilt Neomacs private-X11 verification: both mode lines 23 px
  • cargo nextest run -p neomacs-display-protocol -p neomacs-layout-engine: 2,605 passed, 3 skipped
  • cargo fmt --all -- --check
  • git diff --check

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5d17685f-2530-470e-b70d-0e65b3361c82

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@eval-exec
eval-exec merged commit 010e55e into main Aug 19, 2026
13 of 18 checks passed
@eval-exec
eval-exec deleted the agent/fix-mode-line-face-realization branch August 19, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant