Repository navigation
Fix mode-line face realization - #267
Merged
Merged
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
BasicFaceId::name()mapping for active and inactive window chromeWindowNamedOverFrameDefaultWhy
Selected mode lines were sometimes realized as the
mode-lineparent instead ofmode-line-active, which leaked parent decorations and metrics. Separately, a buffer-localdefaultscale—such astreemacs-text-scale—was incorrectly used as the base for inactive mode-line realization, shrinking window chrome along with buffer text.GNU Emacs realizes each typed basic face from its canonical name and starts window-named realization from the frame's unremapped default. This change follows that boundary while retaining legitimate named face remappings.
Impact
mode-line-activeattributes, including explicit decoration suppressionValidation
cargo nextest run -p neomacs-display-protocol -p neomacs-layout-engine: 2,605 passed, 3 skippedcargo fmt --all -- --checkgit diff --check