Skip to content

build(layout-engine): make freetype-rs bundled feature optional - #202

Merged
eval-exec merged 1 commit into
eval-exec:mainfrom
lonerOrz:fix-flake-build
Jul 28, 2026
Merged

eval-exec merged 1 commit into
eval-exec:mainfrom
lonerOrz:fix-flake-build

Conversation

@lonerOrz

Copy link
Copy Markdown
Contributor

fix flake build

@gemini-code-assist

Copy link
Copy Markdown

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@eval-exec
eval-exec merged commit 5fcb5ae into eval-exec:main Jul 28, 2026
@lonerOrz
lonerOrz deleted the fix-flake-build branch July 28, 2026 03:48
@eval-exec

Copy link
Copy Markdown
Owner

Thank you.

@eval-exec

eval-exec commented Jul 28, 2026 •

Copy link
Copy Markdown
Owner

@lonerOrz after this pr, cargo check on linux ci failed.
I guess we need to add freetype in linux runner's deps.

@lonerOrz

Copy link
Copy Markdown
Contributor Author

@lonerOrz after this pr, cargo check on linux ci failed. I guess we need to add freetype in linux runner's deps.

The libfreetype-dev package in Ubuntu 22.04 is too old. We can enable the bundled feature for cargo check to build with a bundled version of FreeType instead.

@eval-exec

Copy link
Copy Markdown
Owner

Plan to enable bundled freetype for github release ci.
use system freetype in fmt/check/clippy.

@lonerOrz

Copy link
Copy Markdown
Contributor Author

Waiting for commit f5857f3 to complete on GitHub Actions: https://github.com/lonerOrz/neomacs/actions

@eval-exec

eval-exec commented Jul 28, 2026 •

Copy link
Copy Markdown
Owner

Great, but should better aware neomacs's github release artifact have an old glibc system need: #167

@lonerOrz

Copy link
Copy Markdown
Contributor Author

Great, but should better aware neomacs's github release artifact have an old glibc system need: #167

Ubuntu 22.04 requires manually enabling --features bundled; after that, it can be built successfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants