Repository navigation
chore: complete Rust 1.96.1 upgrade - #158
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.github.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Rust version badge in the README to 1.96.1 and refactors the divergence_env_vars test in buffer_local_killring_fileio.rs. The test refactoring replaces a fragile, environment-dependent assertion containing local machine paths with a clean, isolated test case using a localized process-environment list. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
The previous rust-overlay snapshot predated the Rust 1.96.1 release, so fromRustupToolchainFile could not resolve the pinned workspace toolchain.
eval-exec
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
rust-overlayrevision so Nix can resolve Rust 1.96.1.Why
PR #152 updated the canonical
rust-toolchain.toml, but several workflows and documentation references still selected or displayed Rust 1.95.0. The previousrust-overlaylock dated 2026-04-28 also predated the Rust 1.96.1 release, causingnix developto fail withStable 1.96.1 is not available.Impact
All repository Rust version references now agree on 1.96.1.
nix developenters with Rust and Cargo 1.96.1, and the environment-variable parity test no longer depends on one machine's Nix store paths.Validation
rg -F 1.95.0returns no matches.cargo check --workspacepasses.cargo nextest run -p neovm-oracle-tests -E 'test(divergence_env_vars)'passes.nix eval --raw .#devShells.x86_64-linux.default.drvPathpasses.nix develop --command truepasses and reports Rust/Cargo 1.96.1.cargo fmt --all --checkandcargo checkpass.Note
nix flake check --no-buildgets past toolchain resolution but encounters a separate invalid cached source-derivation path while checking the package output; that is outside this development-shell fix.